Bug 141746 - REGRESSION(r180235): It broke the !ENABLE(PROMISES) build
Summary: REGRESSION(r180235): It broke the !ENABLE(PROMISES) build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 141634
  Show dependency tree / graph
 
Reported: 2015-02-17 23:56 PST by Csaba Osztrogonác
Modified: 2015-02-18 00:58 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-02-17 23:56:30 PST 
build log:
../../Source/JavaScriptCore/inspector/JSInjectedScriptHost.cpp: In member function 'JSC::JSValue Inspector::JSInjectedScriptHost::getInternalProperties(JSC::ExecState*)':
../../Source/JavaScriptCore/inspector/JSInjectedScriptHost.cpp:212:9: error: 'JSPromise' was not declared in this scope

The problem is that JSPromise type is used unconditionally,
but it is defined inside ENABLE(PROMISES) guard.
Comment 1 Joseph Pecoraro 2015-02-18 00:56:04 PST 
Oops, somehow I didn't even notice that this was behind an enable flag. I'll fix. Thanks for alerting me.
Comment 2 Joseph Pecoraro 2015-02-18 00:58:07 PST 
Should be fixed by:
http://trac.webkit.org/changeset/180259