Bug 141717 - Throwing from an FTL call IC slow path may result in tag registers being clobbered on 64-bit CPUs
Summary: Throwing from an FTL call IC slow path may result in tag registers being clob...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-17 12:04 PST by Filip Pizlo
Modified: 2015-02-17 12:10 PST (History)
0 users

See Also:

Attachments
the patch (26.89 KB, patch)
2015-02-17 12:06 PST, Filip Pizlo 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-02-17 12:04:10 PST 
Patch forthcoming.
Comment 1 Filip Pizlo 2015-02-17 12:06:04 PST 
Created attachment 246758 [details]
the patch
Comment 2 Geoffrey Garen 2015-02-17 12:08:28 PST 
Comment on attachment 246758 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246758&action=review

r=me

> Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:1849
> +    # Gotta restore the tag registers. We could be throwing from FTL, which may
> +    # clobber them.

I like this comment better than the JIT one -- can you copy it there?
Comment 3 Filip Pizlo 2015-02-17 12:10:31 PST 
Landed in http://trac.webkit.org/changeset/180234