WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
141717
Throwing from an FTL call IC slow path may result in tag registers being clobbered on 64-bit CPUs
https://bugs.webkit.org/show_bug.cgi?id=141717
Summary
Throwing from an FTL call IC slow path may result in tag registers being clob...
Filip Pizlo
Reported
2015-02-17 12:04:10 PST
Patch forthcoming.
Attachments
the patch
(26.89 KB, patch)
2015-02-17 12:06 PST
,
Filip Pizlo
ggaren
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Filip Pizlo
Comment 1
2015-02-17 12:06:04 PST
Created
attachment 246758
[details]
the patch
Geoffrey Garen
Comment 2
2015-02-17 12:08:28 PST
Comment on
attachment 246758
[details]
the patch View in context:
https://bugs.webkit.org/attachment.cgi?id=246758&action=review
r=me
> Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:1849 > + # Gotta restore the tag registers. We could be throwing from FTL, which may > + # clobber them.
I like this comment better than the JIT one -- can you copy it there?
Filip Pizlo
Comment 3
2015-02-17 12:10:31 PST
Landed in
http://trac.webkit.org/changeset/180234
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug