Bug 141673 - The wrong element's style is used for text-decoration-style
Summary: The wrong element's style is used for text-decoration-style
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-16 15:55 PST by Dave Hyatt
Modified: 2015-02-18 11:01 PST (History)
13 users (show)

See Also:


Attachments
Patch (18.64 KB, patch)
2015-02-16 15:58 PST, Dave Hyatt
dino: review+
Details | Formatted Diff | Diff
Patch that works on iOS (19.64 KB, patch)
2015-02-17 10:57 PST, Dave Hyatt
no flags Details | Formatted Diff | Diff
Patch that works on iOS (19.93 KB, patch)
2015-02-17 10:58 PST, Dave Hyatt
dino: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2015-02-16 15:55:42 PST
It should behave like colors and be drawn from the enclosing decorating box's style.
Comment 1 Dave Hyatt 2015-02-16 15:58:01 PST
Created attachment 246694 [details]
Patch
Comment 2 Alexey Proskuryakov 2015-02-16 17:01:39 PST
/Volumes/Data/EWS/WebKit/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:1768:19: error: no member named 'getTextDecorationColors' in 'WebCore::RenderObject'
        renderer->getTextDecorationColors(decor, underline, overline, linethrough);
        ~~~~~~~~  ^
1 error generated.
Comment 3 Dave Hyatt 2015-02-17 10:57:29 PST
Created attachment 246755 [details]
Patch that works on iOS
Comment 4 Dave Hyatt 2015-02-17 10:58:23 PST
Created attachment 246756 [details]
Patch that works on iOS
Comment 5 Dave Hyatt 2015-02-18 11:01:11 PST
Fixed in r180273.