It might be in detached state.
Created attachment 246687 [details] Patch
Comment on attachment 246687 [details] Patch r=me
Comment on attachment 246687 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246687&action=review r=me % nits. > Source/WebCore/rendering/RenderTableRow.h:46 > + RenderTable* table() const Now that this is no longer a one-liner, we may want to move it outside the class and mark it as inline. > Source/WebCore/rendering/RenderTableRow.h:121 > + RenderTableSection* section() const { return downcast<RenderTableSection>(parent()); } Even though they are no outside callers now, I could imagine this getter being useful. Why not keep it public?
Andreas beat me to it :)
(In reply to comment #3) > Comment on attachment 246687 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=246687&action=review > > r=me % nits. > > > Source/WebCore/rendering/RenderTableRow.h:46 > > + RenderTable* table() const > > Now that this is no longer a one-liner, we may want to move it outside the > class and mark it as inline. > Sure. > > Source/WebCore/rendering/RenderTableRow.h:121 > > + RenderTableSection* section() const { return downcast<RenderTableSection>(parent()); } > > Even though they are no outside callers now, I could imagine this getter > being useful. Why not keep it public? I prefer the not public until required policy.
Created attachment 246690 [details] Patch
Created attachment 246692 [details] Patch
Comment on attachment 246692 [details] Patch Clearing flags on attachment: 246692 Committed r180190: <http://trac.webkit.org/changeset/180190>
All reviewed patches have been landed. Closing bug.