Some of the emoji groups and emoji with variations do not render correctly on OS X. rdar://problem/19820463
Created attachment 246670 [details] Patch
Comment on attachment 246670 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246670&action=review > Source/WebCore/ChangeLog:17 > + * dom/Text.h: Moved from RenderText.cpp to make the functions > + available to other parts of the code. Code in the platform directory depend on anything outside the platform directory, so clearly this not the right place for these definitions. They also have nothing to do with the DOM text node. Perhaps you meant for this to move somewhere in platform/text?
(In reply to comment #2) > Code in the platform directory depend on anything […] I meant “should not depend”.
Comment on attachment 246670 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246670&action=review >> Source/WebCore/ChangeLog:17 >> + available to other parts of the code. > > Code in the platform directory depend on anything outside the platform directory, so clearly this not the right place for these definitions. They also have nothing to do with the DOM text node. Perhaps you meant for this to move somewhere in platform/text? You're right, I'll find another place for it.
Comment on attachment 246670 [details] Patch Attachment 246670 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5115057973231616 New failing tests: fast/text/emoji.html
Created attachment 246678 [details] Archive of layout-test-results from ews102 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 246670 [details] Patch Attachment 246670 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6571076683300864 New failing tests: fast/text/emoji.html
Created attachment 246680 [details] Archive of layout-test-results from ews104 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Comment on attachment 246670 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246670&action=review > Source/WebCore/dom/Text.h:89 > +inline bool isEmojiGroupCandidate(UChar32 character) > +{ > + return (character >= 0x1F466 && character <= 0x1F469) || character == 0x2764 || character == 0x1F48B; > +} > + > +inline bool isEmojiModifier(UChar32 character) > +{ > + return character >= 0x1F3FB && character <= 0x1F3FF; > +} > + > +inline bool isVariationSelector(UChar32 character) > +{ > + // U+FE00 through U+FE0F Unicode variation selectors > + return character >= 0xFE00 && character <= 0xFE0F; > +} This is the wrong place for these. These should be somewhere in the platform directory or in WTF since they are used by things like FontCascade. Maybe in TextBoundaries.h? Maybe wtf/unicode/CharacterNames.h? Maybe a new file. > Source/WebCore/platform/graphics/FontCascade.cpp:31 > +#include "Text.h" This is a layering violation.
Created attachment 246693 [details] Patch2 Addresses comments.
Committed revision 180191.