Bug 141644 – Assertion in disk cache code with redirect to a non-http resource

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Antti Koivisto]

ASSERTION FAILED: response.url().protocolIsInHTTPFamily()
/Users/antti/webkit/OpenSource/Source/WebCore/loader/cache/CacheValidation.cpp(106) : double WebCore::computeFreshnessLifetimeForHTTPFamily(const WebCore::ResourceResponse &, double)
1   0x107b7cad0 WTFCrash
2   0x1093b4751 WebCore::computeFreshnessLifetimeForHTTPFamily(WebCore::ResourceResponse const&, double)
3   0x10453d6a7 WebKit::NetworkResourceLoader::didFinishLoading(WebCore::ResourceHandle*, double)
4   0x10b1c6293 __76-[WebCoreResourceHandleAsOperationQueueDelegate connectionDidFinishLoading:]_block_invoke
5   0x7fff92371323 _dispatch_call_block_and_release
6   0x7fff9236cc13 _dispatch_client_callout

[Antti Koivisto]

rdar://problem/19751042

[Antti Koivisto]

Created attachment 246650 [details]
patch

[WebKit Commit Bot]

Comment on attachment 246650 [details]
patch

Clearing flags on attachment: 246650

Committed r180148: <http://trac.webkit.org/changeset/180148>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

Comment on attachment 246650 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246650&action=review

> Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:265
> +    if (!originalRequest.url().protocolIsInHTTPFamily() || !response.isHTTP()) {

This "in HTTP family" vs. "HTTP" naming is quite misleading.

[Antti Koivisto]

How so?

[Alexey Proskuryakov]

The reason for the lengthy "protocolIsInHTTPFamily" name is that it makes it clearer that it includes HTTPS.

"isHTTP" doesn't make that clear, and when in the same line with "protocolIsInHTTPFamily" in particular, it actively hints that it doesn't include https, which is untrue.

[Antti Koivisto]

URLs and responses are quite different types of objects though. To me it seems clear that an "HTTP response" covers HTTPS too (there is no NSHTTPSURLResponse either).

[Alexey Proskuryakov]

> URLs and responses are quite different types of objects though

What is the difference? Both are used for arbitrary URLs, there is no difference at all.

I see your reference to Foundation naming scheme, however it's not a fair comparison, those names are ancient, and they don't need to play well with naming in WebKit.

[Antti Koivisto]

In any case, patches are welcome if you have naming improvements.