Bug 141629 - CSS JIT: finish :nth-last-child()
Summary: CSS JIT: finish :nth-last-child()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-15 18:27 PST by Benjamin Poulain
Modified: 2015-02-16 22:41 PST (History)
3 users (show)

See Also:


Attachments
Patch (705.06 KB, patch)
2015-02-15 18:42 PST, Benjamin Poulain
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-mavericks (529.71 KB, application/zip)
2015-02-15 19:31 PST, Build Bot
no flags Details
Archive of layout-test-results from ews107 for mac-mavericks-wk2 (695.61 KB, application/zip)
2015-02-15 19:36 PST, Build Bot
no flags Details
Patch (710.17 KB, patch)
2015-02-15 23:48 PST, Benjamin Poulain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2015-02-15 18:27:28 PST
CSS JIT: finish :nth-last-child()
Comment 1 Benjamin Poulain 2015-02-15 18:42:59 PST
Created attachment 246630 [details]
Patch
Comment 2 Build Bot 2015-02-15 19:31:22 PST
Comment on attachment 246630 [details]
Patch

Attachment 246630 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5994256032333824

New failing tests:
fast/selectors/several-nth-last-child.html
Comment 3 Build Bot 2015-02-15 19:31:25 PST
Created attachment 246632 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 4 Build Bot 2015-02-15 19:36:12 PST
Comment on attachment 246630 [details]
Patch

Attachment 246630 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5539847418675200

New failing tests:
fast/selectors/several-nth-last-child.html
Comment 5 Build Bot 2015-02-15 19:36:15 PST
Created attachment 246633 [details]
Archive of layout-test-results from ews107 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 6 Benjamin Poulain 2015-02-15 23:48:40 PST
Created attachment 246636 [details]
Patch
Comment 7 Andreas Kling 2015-02-16 14:22:47 PST
Comment on attachment 246636 [details]
Patch

r=me

As we discussed in person, I think we should make querySelector() ignore the parsing-is-finished state and operate on whatever the current state of the DOM is at that point.
I see no reason that e.g a synchronous script that runs during parse shouldn't have a fully-functioning querySelector().
Comment 8 Benjamin Poulain 2015-02-16 20:27:13 PST
Comment on attachment 246636 [details]
Patch

Clearing flags on attachment: 246636

Committed r180206: <http://trac.webkit.org/changeset/180206>
Comment 9 Benjamin Poulain 2015-02-16 20:27:18 PST
All reviewed patches have been landed.  Closing bug.
Comment 10 Alexey Proskuryakov 2015-02-16 21:48:44 PST
fast/selectors/nth-last-child-of-register-requirement.html times out in debug builds: https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fselectors%2Fnth-last-child-of-register-requirement.html
Comment 11 Alexey Proskuryakov 2015-02-16 22:41:05 PST
Filed bug 141695.