The GetArgument node type is bizarre: it acts like a GetLocal that also does checks. We should just use a GetLocal instead and do the checks elsewhere.
Created attachment 246626 [details] work in progress
Created attachment 246627 [details] the patch
Landed in http://trac.webkit.org/changeset/180160
(In reply to comment #3) > Landed in http://trac.webkit.org/changeset/180160 It broke 32 bit API tests, see Apple 32 bit JSC testers for details: JS ERROR JS ERROR undefined: JS ERROR TypeError: null is not an object undefined: JS ERROR TypeError: No default value undefined: JS ERROR TypeError: No default value undefined: JS ERROR TypeError: No default value [native code]: JS ERROR 1 undefined:1: JS ERROR SyntaxError: Unexpected token '=' undefined:1: JS ERROR SyntaxError: Unexpected token '=' undefined:1: JS ERROR SyntaxError: Unexpected identifier 'Array' undefined:1: JS ERROR SyntaxError: Unexpected identifier 'Array' undefined:2: JS ERROR SyntaxError: Unexpected identifier 'Array' file:///foo/bar.js:1: JS ERROR SyntaxError: Unexpected identifier 'Array' test script:1:21: JS ERROR an exception test script:1:21: JS ERROR an exception test script:1:21: JS ERROR an exception test script:1:21: JS ERROR an exception test script:1:21: JS ERROR an exception test script:1:21: JS ERROR an exception test script:1:21: JS ERROR an exception testAPI completed with rc=11 (254)
(In reply to comment #4) > (In reply to comment #3) > > Landed in http://trac.webkit.org/changeset/180160 > > It broke 32 bit API tests, see Apple 32 bit JSC testers for details: > > JS ERROR > JS ERROR > undefined: JS ERROR TypeError: null is not an object > undefined: JS ERROR TypeError: No default value > undefined: JS ERROR TypeError: No default value > undefined: JS ERROR TypeError: No default value > [native code]: JS ERROR 1 > undefined:1: JS ERROR SyntaxError: Unexpected token '=' > undefined:1: JS ERROR SyntaxError: Unexpected token '=' > undefined:1: JS ERROR SyntaxError: Unexpected identifier 'Array' > undefined:1: JS ERROR SyntaxError: Unexpected identifier 'Array' > undefined:2: JS ERROR SyntaxError: Unexpected identifier 'Array' > file:///foo/bar.js:1: JS ERROR SyntaxError: Unexpected identifier 'Array' > test script:1:21: JS ERROR an exception > test script:1:21: JS ERROR an exception > test script:1:21: JS ERROR an exception > test script:1:21: JS ERROR an exception > test script:1:21: JS ERROR an exception > test script:1:21: JS ERROR an exception > test script:1:21: JS ERROR an exception > testAPI completed with rc=11 (254) Did it just break Apple 32-bit or all 32-bit? I ask because I've seen the JSC Xcode project mess up dependency resolutions pretty regularly in recent revisions. It might just need a clean build. If that doesn't fix it then rollout is best.
strange, build works again after an unrelated change - https://build.webkit.org/builders/Apple%20Yosemite%2032-bit%20JSC%20%28BuildAndTest%29/builds/2093