141618 – Fix the C-Loop LLInt build after r180098

Bug 141618 - Fix the C-Loop LLInt build after r180098

Summary: Fix the C-Loop LLInt build after r180098

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Benjamin Poulain

URL:
Keywords:

Duplicates (1):	141649 (view as bug list)
Depends on:
Blocks:	141540
	Show dependency tree / graph

Reported:	2015-02-14 20:23 PST by Benjamin Poulain
Modified:	2015-02-18 01:47 PST (History)
CC List:	10 users (show)

See Also:

Attachments
Patch (44.66 KB, patch) 2015-02-14 20:27 PST, Benjamin Poulain	no flags	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Benjamin Poulain 2015-02-14 20:23:43 PST

Fix the C-Loop LLInt build

Comment 1 Benjamin Poulain 2015-02-14 20:27:17 PST

Created attachment 246614 [details]
Patch

Comment 2 WebKit Commit Bot 2015-02-14 20:29:27 PST

Attachment 246614 [details] did not pass style-queue:

ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:30:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:112:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:113:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:114:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:147:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:149:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:149:  Extra space between int and k  [whitespace/declaration] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:153:  Missing spaces around ==  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:153:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:154:  Missing spaces around |  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:154:  More than one command on the same line in if  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:154:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:158:  More than one command on the same line in if  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:160:  Missing spaces around ==  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:160:  More than one command on the same line in if  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:162:  More than one command on the same line in if  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:162:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:164:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:164:  Missing spaces around |  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:167:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:168:  Else clause should never be on same line as else (use 2 lines)  [whitespace/newline] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:168:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:171:  Missing spaces around |  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:177:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:177:  z_h is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:177:  z_l is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:177:  p_h is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:177:  p_l is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:178:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:179:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:180:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:181:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:183:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:183:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:184:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:185:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:186:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:189:  Missing spaces around |  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:189:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:189:  More than one command on the same line in if  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:189:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:192:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:192:  Missing spaces around ==  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:192:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:192:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:193:  Missing spaces around ==  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:193:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:193:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:202:  Missing spaces around <  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:202:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:203:  Missing spaces around >=  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:203:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:203:  More than one command on the same line in if  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:204:  Missing spaces around >=  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:204:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:206:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:208:  Missing spaces around ==  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:208:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:208:  More than one command on the same line in if  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:209:  Missing spaces around ==  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:209:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:209:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:211:  Missing spaces around ==  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:211:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:211:  More than one command on the same line in if  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:217:  Missing spaces around ==  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:217:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:217:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:218:  Missing spaces around ==  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:219:  Missing spaces around |  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:219:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:219:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:220:  Extra space between return and y  [whitespace/declaration] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:219:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:222:  Missing spaces around >=  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:224:  Missing spaces around <  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:226:  Missing spaces around ==  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:226:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:227:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:227:  Else clause should never be on same line as else (use 2 lines)  [whitespace/newline] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:227:  Missing spaces around /  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:227:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:227:  More than one command on the same line in if  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:228:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:229:  Missing spaces around ==  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:229:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:229:  More than one command on the same line in if  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:230:  Missing spaces around ==  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:230:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:231:  Missing spaces around >=  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:231:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:238:  Missing spaces around ==  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:238:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:238:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:239:  Missing spaces around ==  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:239:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:239:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:239:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:241:  Missing spaces around /  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:241:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:241:  More than one command on the same line in if  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:242:  Missing spaces around <  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:242:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:243:  Missing spaces around |  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:243:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:243:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:244:  Missing spaces around /  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:245:  Missing spaces around ==  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:245:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:255:  Missing spaces around |  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:255:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:255:  More than one command on the same line in if  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:255:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:258:  Missing spaces around |  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:258:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:258:  More than one command on the same line in if  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:258:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:261:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:262:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:262:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:263:  Missing spaces around <=  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:263:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:263:  More than one command on the same line in if  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:264:  Missing spaces around >=  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:264:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:264:  More than one command on the same line in if  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:267:  Missing spaces around <  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:267:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:267:  More than one command on the same line in
 if  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:268:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:268:  More than one command on the same line in if  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:279:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:279:  s_l is incorrectly named. Don't use the single letter 'l' as an identifier name.  [readability/naming] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:279:  t_h is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:279:  t_l is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:282:  Missing spaces around <  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:282:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:283:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:287:  Missing spaces around |  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:288:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:288:  Missing spaces around <=  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:288:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:288:  More than one command on the same line in if  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:289:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:289:  Missing spaces around <  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:289:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:289:  More than one command on the same line in if  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:290:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:290:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:290:  Missing spaces around +=  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:295:  Missing spaces around /  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:301:  Missing spaces around |  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:336:  Missing spaces around >=  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:337:  Missing spaces around |  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:337:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:337:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:337:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:340:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:340:  More than one command on the same line in if  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:341:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:342:  Missing spaces around >=  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:342:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:342:  Extra space before ) in if  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:343:  Missing spaces around |  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:343:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:343:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:343:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:346:  Missing spaces around <=  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:346:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:346:  More than one command on the same line in if  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:347:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:355:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:360:  Missing spaces around |  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:361:  Missing spaces around <  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:361:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:361:  More than one command on the same line in if  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:372:  Missing spaces around /  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:376:  Missing spaces around <=  [whitespace/operators] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:376:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:376:  More than one command on the same line in if  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:376:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:377:  Else clause should never be on same line as else (use 2 lines)  [whitespace/newline] [4]
ERROR: Source/JavaScriptCore/runtime/MathCommon.cpp:377:  __HI is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 183 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Alexey Proskuryakov 2015-02-16 12:38:16 PST

*** Bug 141649 has been marked as a duplicate of this bug. ***

Comment 4 Csaba Osztrogonác 2015-02-17 21:59:09 PST

The cloop build is broken since 4.5 days. Any plan to review this fix?

Comment 5 WebKit Commit Bot 2015-02-18 00:01:13 PST

Comment on attachment 246614 [details]
Patch

Clearing flags on attachment: 246614

Committed r180258: <http://trac.webkit.org/changeset/180258>

Comment 6 WebKit Commit Bot 2015-02-18 00:01:20 PST

All reviewed patches have been landed.  Closing bug.

Comment 7 Csaba Osztrogonác 2015-02-18 01:44:48 PST

(In reply to comment #5)
> Comment on attachment 246614 [details]
> Patch
> 
> Clearing flags on attachment: 246614
> 
> Committed r180258: <http://trac.webkit.org/changeset/180258>

and the Windows buildfix landed in http://trac.webkit.org/changeset/180262.

Just out of curiosity, why did you change the original 
pow to std::pow, which made Windows unhappy?

Comment 8 Benjamin Poulain 2015-02-18 01:47:13 PST

(In reply to comment #7)
> (In reply to comment #5)
> > Comment on attachment 246614 [details]
> > Patch
> > 
> > Clearing flags on attachment: 246614
> > 
> > Committed r180258: <http://trac.webkit.org/changeset/180258>
> 
> and the Windows buildfix landed in http://trac.webkit.org/changeset/180262.
> 
> Just out of curiosity, why did you change the original 
> pow to std::pow, which made Windows unhappy?

As far as I could find, std::pow() was better defined and I also know it lowers to llvm.pow with clang. I switched to that to be on the safe side.