Bug 141613 - [Mac] Possible DDActionContext leaks, RetainPtr cleanup
Summary: [Mac] Possible DDActionContext leaks, RetainPtr cleanup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-14 18:54 PST by Joseph Pecoraro
Modified: 2015-02-14 20:54 PST (History)
2 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (3.71 KB, patch)
2015-02-14 18:56 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[PATCH] Proposed Fix (3.71 KB, patch)
2015-02-14 19:27 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-02-14 18:54:37 PST 
* SUMMARY
Possible DDActionContext leaks based on shadey RetainPtr usage. Expected an adopt and there was none.

  -    RetainPtr<DDActionContext> actionContext = [allocDDActionContextInstance() init];
  +    RetainPtr<DDActionContext> actionContext = adoptNS([allocDDActionContextInstance() init]);
Comment 1 Joseph Pecoraro 2015-02-14 18:56:20 PST 
Created attachment 246607 [details]
[PATCH] Proposed Fix
Comment 2 Joseph Pecoraro 2015-02-14 19:27:49 PST 
Created attachment 246610 [details]
[PATCH] Proposed Fix
Comment 3 Tim Horton 2015-02-14 20:48:56 PST 
Comment on attachment 246610 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=246610&action=review

> Source/WebKit/mac/WebView/WebActionMenuController.mm:280
> +    RetainPtr<DDActionContext> actionContext = adoptNS([allocDDActionContextInstance() init]);

Nothing shady about it, it's just wrong. Good catch!
Comment 4 WebKit Commit Bot 2015-02-14 20:54:35 PST 
Comment on attachment 246610 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 246610

Committed r180119: <http://trac.webkit.org/changeset/180119>
Comment 5 WebKit Commit Bot 2015-02-14 20:54:39 PST 
All reviewed patches have been landed.  Closing bug.