Bug 141588 - Update SPI availability annotations
Summary: Update SPI availability annotations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-13 20:01 PST by mitz
Modified: 2015-02-16 10:56 PST (History)
3 users (show)

See Also:

Attachments
Change some WK_IOS_TBA to 8_3 (2.19 KB, patch)
2015-02-13 20:04 PST, mitz 		andersca: review-
Details | Formatted Diff | Diff
Change some WK_IOS_TBA to 8_3 (2.77 KB, patch)
2015-02-16 08:58 PST, mitz 		no flags Details | Formatted Diff | Diff
Change some WK_IOS_TBA to 8_3 (2.77 KB, patch)
2015-02-16 09:26 PST, mitz 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2015-02-13 20:01:00 PST 
Update SPI availability annotations
Comment 1 mitz 2015-02-13 20:04:09 PST 
Created attachment 246570 [details]
Change some WK_IOS_TBA to 8_3
Comment 2 Darin Adler 2015-02-13 21:54:10 PST 
Comment on attachment 246570 [details]
Change some WK_IOS_TBA to 8_3

Do you know why this broke the EWS build?
Comment 3 Anders Carlsson 2015-02-13 22:39:28 PST 
Comment on attachment 246570 [details]
Change some WK_IOS_TBA to 8_3

Need to fix building on iOS 8.1 (or whatever it is EWS is using).
Comment 4 mitz 2015-02-13 23:22:11 PST 
(In reply to comment #2)
> Comment on attachment 246570 [details]
> Change some WK_IOS_TBA to 8_3
> 
> Do you know why this broke the EWS build?

Yes, __NSi_8_3 is not defined in the 8.1 SDK.
Comment 5 mitz 2015-02-16 08:58:47 PST 
Created attachment 246654 [details]
Change some WK_IOS_TBA to 8_3
Comment 6 WebKit Commit Bot 2015-02-16 09:00:49 PST 
Attachment 246654 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/API/Cocoa/WKFoundation.h:52:  Missing spaces around =  [whitespace/operators] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 mitz 2015-02-16 09:26:23 PST 
Created attachment 246655 [details]
Change some WK_IOS_TBA to 8_3
Comment 8 WebKit Commit Bot 2015-02-16 09:28:22 PST 
Attachment 246655 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/API/Cocoa/WKFoundation.h:52:  Missing spaces around =  [whitespace/operators] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 WebKit Commit Bot 2015-02-16 10:56:16 PST 
Comment on attachment 246655 [details]
Change some WK_IOS_TBA to 8_3

Clearing flags on attachment: 246655

Committed r180158: <http://trac.webkit.org/changeset/180158>
Comment 10 WebKit Commit Bot 2015-02-16 10:56:20 PST 
All reviewed patches have been landed.  Closing bug.