Bug 141579 - rel="noreferrer" should make window.opener null
Summary: rel="noreferrer" should make window.opener null
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
Keywords: InRadar
Depends on:
Reported: 2015-02-13 16:50 PST by Alexey Proskuryakov
Modified: 2015-04-02 15:55 PDT (History)
6 users (show)

See Also:

proposed fix (29.82 KB, patch)
2015-02-13 16:59 PST, Alexey Proskuryakov
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-mavericks-wk2 (672.79 KB, application/zip)
2015-02-13 17:42 PST, Build Bot
no flags Details
proposed fix (29.76 KB, patch)
2015-02-13 21:59 PST, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2015-02-13 16:50:58 PST
That's what the spec says, and what other browsers do.

See also: rdar://problem/19640886
Comment 1 Alexey Proskuryakov 2015-02-13 16:59:15 PST
Created attachment 246556 [details]
proposed fix
Comment 2 Build Bot 2015-02-13 17:42:10 PST
Comment on attachment 246556 [details]
proposed fix

Attachment 246556 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5608730104168448

New failing tests:
Comment 3 Build Bot 2015-02-13 17:42:14 PST
Created attachment 246563 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 4 Alexey Proskuryakov 2015-02-13 21:59:59 PST
Created attachment 246584 [details]
proposed fix

Forgot to remove an experimental change.
Comment 5 Darin Adler 2015-02-13 22:03:32 PST
Comment on attachment 246584 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=246584&action=review

> Source/WebCore/loader/FrameLoader.h:110
>      WEBCORE_EXPORT void loadFrameRequest(const FrameLoadRequest&, LockHistory, LockBackForwardList, // Called by submitForm, calls loadPostRequest and loadURL.
> -        PassRefPtr<Event>, PassRefPtr<FormState>, ShouldSendReferrer, AllowNavigationToInvalidURL);
> +        PassRefPtr<Event>, PassRefPtr<FormState>, ShouldSendReferrer, AllowNavigationToInvalidURL, NewFrameOpenerPolicy);

This is really getting out of hand. I think we need to group these arguments all into an object rather than passing them all separately. Maybe just a struct?
Comment 6 Alexey Proskuryakov 2015-02-13 22:07:48 PST
I think that we already have one struct, FrameLoadRequest, but I'm not sure what belongs to it, and what doesn't.

We may or may not want to try aligning with HTML5 terminology along the way. My concern is that the way the spec describes relationships between browsing contexts is quite complex.
Comment 7 WebKit Commit Bot 2015-02-14 10:16:09 PST
Comment on attachment 246584 [details]
proposed fix

Clearing flags on attachment: 246584

Committed r180110: <http://trac.webkit.org/changeset/180110>
Comment 8 WebKit Commit Bot 2015-02-14 10:16:12 PST
All reviewed patches have been landed.  Closing bug.
Comment 9 Brady Eidson 2015-04-02 15:55:07 PDT
This was in radar as rdar://problem/20306425