Bug 141577 - REGRESSION(r180060) New js/regress-141098 test crashes when LLInt is disabled.
Summary: REGRESSION(r180060) New js/regress-141098 test crashes when LLInt is disabled.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks: 141098
  Show dependency treegraph
 
Reported: 2015-02-13 14:33 PST by Michael Saboff
Modified: 2015-02-13 14:46 PST (History)
2 users (show)

See Also:


Attachments
Patch (3.08 KB, patch)
2015-02-13 14:39 PST, Michael Saboff
benjamin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2015-02-13 14:33:56 PST
jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-no-llint: Regression test for https://webkit.org/b/141098. Make sure eval() properly handles running out of stack space. This test should run without crashing.
jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-no-llint: 
jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-no-llint: On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-no-llint: 
jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-no-llint: 
jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-no-llint: test_script_9825: line 2:  1584 Segmentation fault      "$@" ../../../../.vm/JavaScriptCore.framework/Resources/jsc --useFTLJIT\=false --enableFunctionDotArguments\=true --useLLInt\=false resources/standalone-pre.js regress-141098.js resources/standalone-post.js
jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-no-llint: ERROR: Unexpected exit code: 139
FAIL: jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-no-llint

Need to make a similar stack check to the Baseline JIT.
Comment 1 Michael Saboff 2015-02-13 14:39:44 PST
Created attachment 246550 [details]
Patch
Comment 2 Benjamin Poulain 2015-02-13 14:44:39 PST
Comment on attachment 246550 [details]
Patch

rs=me
Comment 3 Michael Saboff 2015-02-13 14:46:54 PST
Committed r180083: <http://trac.webkit.org/changeset/180083>