WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
141574
Simplify ASSERT in lastRubyRun()
https://bugs.webkit.org/show_bug.cgi?id=141574
Summary
Simplify ASSERT in lastRubyRun()
zalan
Reported
2015-02-13 14:03:29 PST
ASSERT(!child || is<RenderRubyRun>(*child) || child->isBeforeContent() || child == rubyBeforeBlock(ruby)); is complex and redundant after
r180064
Attachments
Patch
(1.60 KB, patch)
2015-02-13 14:09 PST
,
zalan
dbates
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
zalan
Comment 1
2015-02-13 14:09:55 PST
Created
attachment 246547
[details]
Patch
Daniel Bates
Comment 2
2015-02-13 14:13:50 PST
Comment on
attachment 246547
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=246547&action=review
> Source/WebCore/rendering/RenderRuby.cpp:111 > +
Nit: I don't feel that this empty line improves the readability of this code.
zalan
Comment 3
2015-02-13 14:26:59 PST
http://trac.webkit.org/changeset/180081
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug