Bug 141574 - Simplify ASSERT in lastRubyRun()
Summary: Simplify ASSERT in lastRubyRun()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-13 14:03 PST by zalan
Modified: 2015-02-13 14:26 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.60 KB, patch)
2015-02-13 14:09 PST, zalan
dbates: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2015-02-13 14:03:29 PST
ASSERT(!child || is<RenderRubyRun>(*child) || child->isBeforeContent() || child == rubyBeforeBlock(ruby)); is complex and redundant after r180064
Comment 1 zalan 2015-02-13 14:09:55 PST
Created attachment 246547 [details]
Patch
Comment 2 Daniel Bates 2015-02-13 14:13:50 PST
Comment on attachment 246547 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246547&action=review

> Source/WebCore/rendering/RenderRuby.cpp:111
> +

Nit: I don't feel that this empty line improves the readability of this code.
Comment 3 zalan 2015-02-13 14:26:59 PST
http://trac.webkit.org/changeset/180081