Bug 141572 - RenderListItem resets its marker's style on style change even if the diff is StyleDifferenceEqual
Summary: RenderListItem resets its marker's style on style change even if the diff is ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-02-13 12:13 PST by Chris Dumez
Modified: 2015-02-13 16:37 PST (History)
6 users (show)

See Also:


Attachments
Patch (2.38 KB, patch)
2015-02-13 12:27 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (4.77 KB, patch)
2015-02-13 15:35 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (4.76 KB, patch)
2015-02-13 15:52 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-02-13 12:13:41 PST
RenderListItem resets its marker's style on style change even if the diff is StyleDifferenceEqual.

This causes high cpu usage on http://www.nokogiri.org/tutorials/searching_a_xml_html_document.html because there is an animation that changes the style every second and the RenderListItem keeps resetting its marker's margin, which triggers a layout and the RenderListMarker re-computes its margin during layout and updates its style again.

Radar: rdar://problem/19759818
Comment 1 Chris Dumez 2015-02-13 12:27:11 PST
Created attachment 246540 [details]
Patch
Comment 2 Chris Dumez 2015-02-13 15:35:30 PST
Created attachment 246553 [details]
Patch
Comment 3 Chris Dumez 2015-02-13 15:52:21 PST
Created attachment 246554 [details]
Patch
Comment 4 WebKit Commit Bot 2015-02-13 16:37:48 PST
Comment on attachment 246554 [details]
Patch

Clearing flags on attachment: 246554

Committed r180090: <http://trac.webkit.org/changeset/180090>
Comment 5 WebKit Commit Bot 2015-02-13 16:37:54 PST
All reviewed patches have been landed.  Closing bug.