Bug 141569 - [Mac, iOS] Adjust pagination behavior for Mail.app printing use
Summary: [Mac, iOS] Adjust pagination behavior for Mail.app printing use
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks: 144366
  Show dependency treegraph
 
Reported: 2015-02-13 11:23 PST by Brent Fulgham
Modified: 2015-04-28 17:53 PDT (History)
8 users (show)

See Also:


Attachments
Patch (8.19 KB, patch)
2015-02-13 11:31 PST, Brent Fulgham
no flags Details | Formatted Diff | Diff
Patch (10.45 KB, patch)
2015-02-13 12:28 PST, Brent Fulgham
no flags Details | Formatted Diff | Diff
Patch (10.27 KB, patch)
2015-02-13 13:26 PST, Brent Fulgham
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2015-02-13 11:23:36 PST
Certain uses of iframe elements in WebKit clients can cause undesirable printing behavior. WebKit attempts to keep all contents of an iframe together on the same page, but in some cases that does not produce good looking print output.

This bug provides a new setting that allows the default printing behavior to be overridden.
Comment 1 Brent Fulgham 2015-02-13 11:28:27 PST
<rdar://problem/14912763>
Comment 2 Brent Fulgham 2015-02-13 11:31:43 PST
Created attachment 246537 [details]
Patch
Comment 3 Brent Fulgham 2015-02-13 12:28:20 PST
Created attachment 246541 [details]
Patch
Comment 4 Anders Carlsson 2015-02-13 12:33:29 PST
Comment on attachment 246541 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246541&action=review

> Source/WebCore/rendering/RenderBlockFlow.cpp:1617
> +static const AtomicString& messageContainerName()
> +{
> +    static NeverDestroyed<AtomicString> messageContainerNameString("messageContentContainer", AtomicString::ConstructFromLiteral);
> +    return messageContainerNameString;
> +}

It's bad to use AtomicString inside NeverDestroyed since they are different for different threads. I'd just use a literal in the function below instead.
Comment 5 Brent Fulgham 2015-02-13 13:26:15 PST
Created attachment 246545 [details]
Patch
Comment 6 Brent Fulgham 2015-02-13 13:34:43 PST
(In reply to comment #4)
> Comment on attachment 246541 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=246541&action=review
> 
> > Source/WebCore/rendering/RenderBlockFlow.cpp:1617
> > +static const AtomicString& messageContainerName()
> > +{
> > +    static NeverDestroyed<AtomicString> messageContainerNameString("messageContentContainer", AtomicString::ConstructFromLiteral);
> > +    return messageContainerNameString;
> > +}
> 
> It's bad to use AtomicString inside NeverDestroyed since they are different
> for different threads. I'd just use a literal in the function below instead.

OK!
Comment 7 Brent Fulgham 2015-02-13 13:56:06 PST
Committed r180076: <http://trac.webkit.org/changeset/180076>