Bug 141568 - CachedResource::clearLoader() should self-destruct if nothing else retains the CachedResource.
Summary: CachedResource::clearLoader() should self-destruct if nothing else retains th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-13 10:47 PST by Andreas Kling
Modified: 2015-02-13 12:30 PST (History)
2 users (show)

See Also:


Attachments
Patch (1.73 KB, patch)
2015-02-13 10:50 PST, Andreas Kling
koivisto: review+
Details | Formatted Diff | Diff
Patch for landing (1.75 KB, patch)
2015-02-13 10:54 PST, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2015-02-13 10:47:25 PST
Anyone who may change the return value of CachedResource::canDelete() is responsible for calling deleteIfPossible() afterwards.
Comment 1 Andreas Kling 2015-02-13 10:50:22 PST
Created attachment 246533 [details]
Patch
Comment 2 Andreas Kling 2015-02-13 10:54:02 PST
Created attachment 246535 [details]
Patch for landing
Comment 3 WebKit Commit Bot 2015-02-13 12:30:40 PST
Comment on attachment 246535 [details]
Patch for landing

Clearing flags on attachment: 246535

Committed r180068: <http://trac.webkit.org/changeset/180068>
Comment 4 WebKit Commit Bot 2015-02-13 12:30:44 PST
All reviewed patches have been landed.  Closing bug.