Bug 141560 - Implement video hole punching
Summary: Implement video hole punching
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2015-02-13 05:51 PST by Julien Isorce
Modified: 2019-05-02 16:18 PDT (History)
13 users (show)

See Also:

Implement video hole punching (23.88 KB, patch)
2015-02-13 05:53 PST, Julien Isorce
sam: review-
Details | Formatted Diff | Diff
2 html examples to illustrate hole punching feature. (1.93 KB, text/plain)
2015-02-13 06:17 PST, Julien Isorce
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Isorce 2015-02-13 05:51:35 PST
Similar to VIDEO_HOLE from chromium except that in the following patch it can be activated through the new -webkit-hole value of video tag 's background property.

Example: <video background="-webkit-hole"></video>
Comment 1 Julien Isorce 2015-02-13 05:53:10 PST
Created attachment 246519 [details]
Implement video hole punching
Comment 2 WebKit Commit Bot 2015-02-13 05:55:05 PST
Attachment 246519 [details] did not pass style-queue:

ERROR: Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:94:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
Total errors found: 1 in 17 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Julien Isorce 2015-02-13 06:17:00 PST
Created attachment 246520 [details]
2 html examples to illustrate hole punching feature.

(I plan to write some layout tests)
Comment 4 Sam Weinig 2015-02-13 11:58:43 PST
Comment on attachment 246519 [details]
Implement video hole punching

This is not something we want to support in WebKit.  As Simon noted on webkit-dev, "[hole] is really just adapting to a limitation of the platform’s compositing architecture".
Comment 5 Julien Isorce 2015-02-14 03:19:09 PST
Hole punching is also useful for protected content.

Actually the hardware here is really powerful and zero-copy capable (from CPU point of view) for HW decoding into GL rendering. But this way is still not suitable for protected content.

The attached patch should have been submitted just after the webkit-dev discussion but for priority reasons it has been delayed.

Speaking about the webkit-dev discussion, it was clear for me that a new <hole> tag is definitely a no. But I thought that a capability of <video> tag would have been considered: "The right solution for a WebKit implementation would be to solve this via the accelerated composting code. Just use a <video> or <object> in your markup, then implement the hole-punching via the GraphicsLayer subsystem."

It is worth to mention that the implementation is independent of the UI tool kit port. Though I only tested it on GTK and EFL. Also there are 2 parts in this patch, the main part about the platform layer that punch through at compositing time. And the second part that parses background=-webkit-hole for a video tag.
In fact in chromium you only have something similar in principle to the first part, so nothing exposed directly from javascript.

There is a very recent discussion on chromium-dev about EME and hole punching: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/P8MDgY9f1RE 

I see hole punching as an intermediate solution until the good solution will be widely supported by the hardware: "GPU support for composition of protected video " (through OpenGL) 

In any case we were happy to share the code so serve as generic example, demo or anything else.

If it gets interest soon or later in the future, even just few parts of the patch, feel free to reopen the bug and I will be happy to rebase it.