Bug 141559 – WorkQueue should support concurrent queues

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Antti Koivisto]

Currently it only does serial.

[Antti Koivisto]

Created attachment 246516 [details]
patch

[Antti Koivisto]

Created attachment 246518 [details]
iOS build fix

[Build Bot]

Comment on attachment 246518 [details]
iOS build fix

Attachment 246518 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6659487410683904

New failing tests:
fast/frames/frame-limit.html

[Build Bot]

Created attachment 246521 [details]
Archive of layout-test-results from ews107 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Antti Koivisto]

Created attachment 246528 [details]
without the qos change

[Anders Carlsson]

Comment on attachment 246528 [details]
without the qos change

View in context: https://bugs.webkit.org/attachment.cgi?id=246528&action=review

> Source/WebKit2/UIProcess/Launcher/ProcessLauncher.cpp:38
> +    static NeverDestroyed<Ref<WorkQueue>> processLauncherWorkQueue { WorkQueue::create("com.apple.WebKit.ProcessLauncher") };

No need to use NeverDestroyed with a smart pointer type.

[Antti Koivisto]

https://trac.webkit.org/r180054

[Sam Weinig]

Comment on attachment 246528 [details]
without the qos change

View in context: https://bugs.webkit.org/attachment.cgi?id=246528&action=review

> Source/WebKit2/Shared/mac/SecItemShim.cpp:181
> +    connection->addWorkQueueMessageReceiver(Messages::SecItemShim::messageReceiverName(), &m_queue.get(), this);

You can do m_queue.ptr() here.

> Source/WebKit2/WebProcess/Plugins/PluginProcessConnectionManager.cpp:61
> +    connection->addWorkQueueMessageReceiver(Messages::PluginProcessConnectionManager::messageReceiverName(), &m_queue.get(), this);

&m_queue.get() -> m_queue.ptr()

> Source/WebKit2/WebProcess/WebPage/EventDispatcher.cpp:90
> +    connection->addWorkQueueMessageReceiver(Messages::EventDispatcher::messageReceiverName(), &m_queue.get(), this);

&m_queue.get() -> m_queue.ptr()

> Source/WebKit2/WebProcess/WebPage/ViewUpdateDispatcher.cpp:55
> +    connection->addWorkQueueMessageReceiver(Messages::ViewUpdateDispatcher::messageReceiverName(), &m_queue.get(), this);

&m_queue.get() -> m_queue.ptr()