RESOLVED FIXED 141556
[BMalloc] Add a FIXME comment for memory alignas 
https://bugs.webkit.org/show_bug.cgi?id=141556
Summary [BMalloc] Add a FIXME comment for memory alignas
Gyuyoung Kim
Reported 2015-02-12 23:37:10 PST
SSIA
Attachments
Patch (2.17 KB, patch)
2015-02-12 23:38 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2015-02-12 23:38:35 PST
Created attachment 246512 [details] Patch
Csaba Osztrogonác
Comment 2 2015-02-13 00:39:44 PST
Comment on attachment 246512 [details] Patch rs=me
WebKit Commit Bot
Comment 3 2015-02-13 01:43:34 PST
Comment on attachment 246512 [details] Patch Clearing flags on attachment: 246512 Committed r180037: <http://trac.webkit.org/changeset/180037>
WebKit Commit Bot
Comment 4 2015-02-13 01:43:38 PST
All reviewed patches have been landed. Closing bug.
Geoffrey Garen
Comment 5 2015-02-13 10:38:11 PST
I don't think it's useful to put a FIXME next to every compiler workaround. The main problem with a compiler workaround is that it makes the code more verbose and cluttered. Adding a FIXME makes it even more verbose and cluttered.
Gyuyoung Kim
Comment 6 2015-02-15 01:13:32 PST
(In reply to comment #5) > I don't think it's useful to put a FIXME next to every compiler workaround. > The main problem with a compiler workaround is that it makes the code more > verbose and cluttered. Adding a FIXME makes it even more verbose and > cluttered. I see. I will try not to add unnecessary FIXME. When this workaround is not needed anymore, I will remove it.
Note You need to log in before you can comment on or make changes to this bug.