Bug 141556 - [BMalloc] Add a FIXME comment for memory alignas
Summary: [BMalloc] Add a FIXME comment for memory alignas
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-12 23:37 PST by Gyuyoung Kim
Modified: 2020-10-19 13:01 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.17 KB, patch)
2015-02-12 23:38 PST, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2015-02-12 23:37:10 PST 
SSIA
Comment 1 Gyuyoung Kim 2015-02-12 23:38:35 PST 
Created attachment 246512 [details]
Patch
Comment 2 Csaba Osztrogonác 2015-02-13 00:39:44 PST 
Comment on attachment 246512 [details]
Patch

rs=me
Comment 3 WebKit Commit Bot 2015-02-13 01:43:34 PST 
Comment on attachment 246512 [details]
Patch

Clearing flags on attachment: 246512

Committed r180037: <http://trac.webkit.org/changeset/180037>
Comment 4 WebKit Commit Bot 2015-02-13 01:43:38 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Geoffrey Garen 2015-02-13 10:38:11 PST 
I don't think it's useful to put a FIXME next to every compiler workaround. The main problem with a compiler workaround is that it makes the code more verbose and cluttered. Adding a FIXME makes it even more verbose and cluttered.
Comment 6 Gyuyoung Kim 2015-02-15 01:13:32 PST 
(In reply to comment #5)
> I don't think it's useful to put a FIXME next to every compiler workaround.
> The main problem with a compiler workaround is that it makes the code more
> verbose and cluttered. Adding a FIXME makes it even more verbose and
> cluttered.

I see. I will try not to add unnecessary FIXME. When this workaround is not needed anymore, I will remove it.