Bug 141553 - Call updateMargins() from RenderListMarker::layout()
Summary: Call updateMargins() from RenderListMarker::layout()
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-12 22:17 PST by Chris Dumez
Modified: 2015-02-13 12:53 PST (History)
4 users (show)

See Also:

Attachments
WIP Patch (1.24 KB, patch)
2015-02-12 22:18 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-02-12 22:17:47 PST 
Call updateMargins() from RenderListMarker::layout() instead of computePreferredLogicalWidths().
Comment 1 Chris Dumez 2015-02-12 22:18:31 PST 
Created attachment 246509 [details]
WIP Patch
Comment 2 WebKit Commit Bot 2015-02-12 22:19:40 PST 
Attachment 246509 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderListMarker.cpp:1529:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/WebCore/rendering/RenderListMarker.cpp:1643:  Should have a space between // and comment  [whitespace/comments] [4]
Total errors found: 2 in 1 files


If any of these errors are false positives, please file a bug against check-webkit-style.