RESOLVED FIXED 141545
Crash removing RemoteLayerTreeDisplayRefreshMonitor from the drawing area's map 
https://bugs.webkit.org/show_bug.cgi?id=141545
Summary Crash removing RemoteLayerTreeDisplayRefreshMonitor from the drawing area's map
Tim Horton
Reported 2015-02-12 17:21:11 PST
Crash removing RemoteLayerTreeDisplayRefreshMonitor from the drawing area's map
Attachments
Patch (5.15 KB, patch)
2015-02-12 17:21 PST, Tim Horton 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2015-02-12 17:21:26 PST
Created attachment 246494 [details] Patch
Simon Fraser (smfr)
Comment 2 2015-02-12 17:31:32 PST
Comment on attachment 246494 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246494&action=review r- for a test. > Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:87 > + // UnsignedWithZeroKeyHashTraits, which uses uint32_t::max and max - 1 as special values in that case. > + webPage.windowScreenDidChange(std::numeric_limits<uint32_t>::max() - 2 - webPage.pageID()); Please remove the -2 and simplify the comment.
Tim Horton
Comment 3 2015-02-12 19:47:25 PST
I'm not sure it's possible to write a test right now, because rAF doesn't seem to work in the hacked up WKViewIOS-based WKTR. I'll try to write one on Mac, but nobody runs the tests with --remote-layer-tree yet.
Simon Fraser (smfr)
Comment 4 2015-02-12 20:45:55 PST
Comment on attachment 246494 [details] Patch OK
Tim Horton
Comment 5 2015-02-12 22:48:32 PST
http://trac.webkit.org/changeset/180031
Note You need to log in before you can comment on or make changes to this bug.