Bug 141518 - [buildbot] Enable run-api-tests on release Mac bots
Summary: [buildbot] Enable run-api-tests on release Mac bots
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-12 09:55 PST by Csaba Osztrogonác
Modified: 2015-02-14 00:56 PST (History)
9 users (show)

See Also:

Attachments
Patch (3.36 KB, patch)
2015-02-12 09:59 PST, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
Patch (3.45 KB, patch)
2015-02-12 11:45 PST, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-02-12 09:55:50 PST 
http://trac.webkit.org/changeset/112734 disabled it long long time ago due to bug82652.

I tested locally, it works fine on my Mavericks machine. I think it works everywhere,
but you might simply forgot to reenable this test on the release bots. Please double check.
Comment 1 Csaba Osztrogonác 2015-02-12 09:59:10 PST 
Created attachment 246449 [details]
Patch

Enable run-api-tests and minor cleanups: pass --no-build unconditionally and remove RunUnitTests() step from the TestFactory which isn't used by Mac and Win.
Comment 2 Alexey Proskuryakov 2015-02-12 11:38:32 PST 
I am not aware of any intentional fix that would have addressed the problem. Looking at related bugs, I see a comment that this may have been fixed by making gtest build with libc++.

Stephanie, can you confirm, and clean up the state of bug 82652 and rdar://problem/11149812?
Comment 3 Csaba Osztrogonác 2015-02-12 11:45:41 PST 
Created attachment 246458 [details]
Patch

typo fixed in the changelog (bug title(
Comment 4 WebKit Commit Bot 2015-02-14 00:56:36 PST 
Comment on attachment 246458 [details]
Patch

Clearing flags on attachment: 246458

Committed r180106: <http://trac.webkit.org/changeset/180106>
Comment 5 WebKit Commit Bot 2015-02-14 00:56:41 PST 
All reviewed patches have been landed.  Closing bug.