WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
141499
[Win] [64-bit] Remove MSVC 2013 FMA3 Bug Workaround
https://bugs.webkit.org/show_bug.cgi?id=141499
Summary
[Win] [64-bit] Remove MSVC 2013 FMA3 Bug Workaround
Brent Fulgham
Reported
2015-02-11 21:32:24 PST
At Microsoft's suggestion, we have disabled FMA3 support for 64-bit builds due to a bug in the MSVC 2013 runtime libraries. When we switch to Visual Studio 2015 (or newer), where this bug is fixed, we should remove this workaround so that we can enjoy the improved vector instruction support. See <
https://connect.microsoft.com/VisualStudio/feedback/details/811093/visual-studio-2013-rtm-c-x64-code-generation-bug-for-avx2-instructions
> for some comments from Microsoft on this topic.
Attachments
Patch
(16.99 KB, patch)
2016-03-22 14:07 PDT
,
peavo
bfulgham
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2015-02-11 21:33:23 PST
<
rdar://problem/19808410
>
Brent Fulgham
Comment 2
2016-03-22 10:40:44 PDT
Per: If you have a spare minute, would you mind removing this old work-around, now that we are standardized on VS2015? Basically this task is to roll out <
http://trac.webkit.org/changeset/179993
>.
peavo
Comment 3
2016-03-22 12:05:42 PDT
(In reply to
comment #2
)
> Per: If you have a spare minute, would you mind removing this old > work-around, now that we are standardized on VS2015? > > Basically this task is to roll out <
http://trac.webkit.org/changeset/179993
>.
No problem, I'll create a patch :)
peavo
Comment 4
2016-03-22 14:07:28 PDT
Created
attachment 274683
[details]
Patch
Brent Fulgham
Comment 5
2016-03-22 14:49:31 PDT
Comment on
attachment 274683
[details]
Patch r=me. Please make sure Windows EWS is happy before landing! :-)
peavo
Comment 6
2016-03-22 14:53:25 PDT
(In reply to
comment #5
)
> Comment on
attachment 274683
[details]
> Patch > > r=me. Please make sure Windows EWS is happy before landing! :-)
Thanks for reviewing!
peavo
Comment 7
2016-03-22 15:21:36 PDT
Committed
r198559
: <
http://trac.webkit.org/changeset/198559
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug