Bug 141492 - extract-localizable-strings.pl shouldn't update the target file if the contents haven't changed
Summary: extract-localizable-strings.pl shouldn't update the target file if the conten...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Rowe (bdash)
Depends on:
Reported: 2015-02-11 14:16 PST by Mark Rowe (bdash)
Modified: 2015-02-11 15:14 PST (History)
2 users (show)

See Also:

Patch (2.29 KB, patch)
2015-02-11 14:21 PST, Mark Rowe (bdash)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2015-02-11 14:16:57 PST
extract-localizable-strings.pl is typically run unconditionally during the build since it's difficult to get the dependencies right. The current behavior results in the output file always being updated, which results in Xcode always needing to copy the file into the framework. This has a flow-on effect of causing any dependent targets to be relinked against the framework. There are two ways to address this:
1) Only run extract-localizable-strings.pl if any of the files it considers have changed. This is difficult to arrange for with Xcode's build system, and would be cumbersome even with make.
2) Only update the target file if the new localizable strings are different from the existing localizable strings.

This patch will take option 2.
Comment 1 Mark Rowe (bdash) 2015-02-11 14:21:48 PST
Created attachment 246415 [details]
Comment 2 WebKit Commit Bot 2015-02-11 15:14:36 PST
Comment on attachment 246415 [details]

Clearing flags on attachment: 246415

Committed r179970: <http://trac.webkit.org/changeset/179970>
Comment 3 WebKit Commit Bot 2015-02-11 15:14:39 PST
All reviewed patches have been landed.  Closing bug.