Bug 141480 - Regression(r179166): Crash when accessing document.dir on a document with no elements
Summary: Regression(r179166): Crash when accessing document.dir on a document with no ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks: 140922
  Show dependency tree / graph
 
Reported: 2015-02-11 10:42 PST by Sam Weinig
Modified: 2015-02-11 15:40 PST (History)
5 users (show)

See Also:

Attachments
Test case (162 bytes, text/html)
2015-02-11 10:50 PST, Sam Weinig 		no flags Details
Patch (3.47 KB, patch)
2015-02-11 13:54 PST, Sam Weinig 		cdumez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2015-02-11 10:42:26 PST 
Crash when accessing document.dir on a document with no elements
Comment 1 Sam Weinig 2015-02-11 10:50:10 PST 
Created attachment 246397 [details]
Test case
Comment 2 Chris Dumez 2015-02-11 11:49:56 PST 
Are you going to work on this? Otherwise, I am happy to take it since I caused the regression it seems.
Comment 3 Chris Dumez 2015-02-11 11:53:54 PST 
https://bugs.webkit.org/show_bug.cgi?id=140922#c5
Comment 4 Sam Weinig 2015-02-11 13:54:57 PST 
Created attachment 246412 [details]
Patch
Comment 5 Chris Dumez 2015-02-11 13:57:25 PST 
Comment on attachment 246412 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246412&action=review

r=me % nit, thanks for fixing.

> LayoutTests/fast/dom/document-dir-empty-document-crash.html:16
> +shouldBe('doc.dir', '""');

nit: shouldBeEmptyString()
Comment 6 Chris Dumez 2015-02-11 14:00:25 PST 
Comment on attachment 246412 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246412&action=review

> Source/WebCore/ChangeLog:3
> +        Crash when accessing document.dir on a document with no elements

Outdated bug title.
Comment 7 Radar WebKit Bug Importer 2015-02-11 15:34:16 PST 
<rdar://problem/19804351>
Comment 8 Sam Weinig 2015-02-11 15:40:15 PST 
Committed r179971: <http://trac.webkit.org/changeset/179971>