URLs: http://stackoverflow.com/q/76564/453435, http://www.w3.org/TR/css3-lists/#marker-pseudo-element Steps to reproduce the problem: 1. Create a webpage with bulleted lists. Do not use any stylesheets that remove the markers from lists. 2. Create a CSS stylesheet that specifies, using the ::marker pseudo-element, how these markers should look/behave, as specified by the W3C CSS3 Working Draft. Expected result: Markers are modified as specified. Actual result: Markers remain unmodified.
Do it.
Created attachment 316407 [details] Work-in-progress patch Work-in-progress patch. The CSS Lists Module Level 3 is still in flux with regards to extended capabilities for ::marker. It does define and refer to CSS Pseudo-Elements Module Level 4 with reagrds to an initial definition for ::marker. I implemented this initial definition. I did not guard ::marker behind a runtime/compile-time flag. I will look into that shortly.
One issue I ran into when writing the included test, http/wpt/css/css-pseudo-4/marker-font-properties.html, is that the baseline position of a marker with a font-size differs from the baseline position of a list item with the same font-size (why?). For now, I added a dummy <span> in http/wpt/css/css-pseudo-4/marker-font-properties.html so that the result will match the expected rendering of http/wpt/css/css-pseudo-4/marker-font-properties-expected.html. I plan to submit all the included tests in http/wpt/css/css-pseudo-4 to the Web Platform Tests repository either before or after this patch is landed. If it is before this patch lands then I will update this patch to import the submitted Web Platform Tests. Otherwise, I will do this in a follow up bug.
Created attachment 316473 [details] Patch and layout tests (without compile-time guard)
Created attachment 316475 [details] Patch and layout tests (without compile-time guard)
Created attachment 316476 [details] Patch and layout tests (with compile-time guard)
Attachment 316476 [details] did not pass style-queue: ERROR: Source/WebKit/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] ERROR: Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] ERROR: Source/WebCore/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] ERROR: Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] ERROR: Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] Total errors found: 5 in 37 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 316479 [details] Patch and layout tests (with compile-time guard)
Comment on attachment 316479 [details] Patch and layout tests (with compile-time guard) Attachment 316479 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4192588 New failing tests: inspector/css/shadow-scoped-style.html
Created attachment 316490 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 316479 [details] Patch and layout tests (with compile-time guard) Attachment 316479 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4192604 New failing tests: inspector/css/shadow-scoped-style.html
Created attachment 316491 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 316479 [details] Patch and layout tests (with compile-time guard) Attachment 316479 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4192621 New failing tests: inspector/css/shadow-scoped-style.html
Created attachment 316493 [details] Archive of layout-test-results from ews114 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 316786 [details] Patch and layout tests (without compile-time guard)
Created attachment 316787 [details] Patch and layout tests (with compile-time guard)
Created attachment 316788 [details] Patch and layout tests (with compile-time guard)
Comment on attachment 316786 [details] Patch and layout tests (without compile-time guard) Attachment 316786 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4229953 New failing tests: http/wpt/css/css-pseudo-4/marker-font-properties.html
Created attachment 316790 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 316786 [details] Patch and layout tests (without compile-time guard) Attachment 316786 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4229965 New failing tests: http/wpt/css/css-pseudo-4/marker-font-properties.html
Created attachment 316791 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 316786 [details] Patch and layout tests (without compile-time guard) Attachment 316786 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4229977 New failing tests: http/wpt/css/css-pseudo-4/marker-font-properties.html
Created attachment 316792 [details] Archive of layout-test-results from ews117 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 316786 [details] Patch and layout tests (without compile-time guard) Attachment 316786 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4229989 New failing tests: http/wpt/css/css-pseudo-4/marker-font-properties.html
Created attachment 316793 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Created attachment 316800 [details] Patch and layout tests (without compile-time guard)
Comment on attachment 316800 [details] Patch and layout tests (without compile-time guard) r=me
Comment on attachment 316800 [details] Patch and layout tests (without compile-time guard) Clearing flags on attachment: 316800 Committed r220207: <http://trac.webkit.org/changeset/220207>
All reviewed patches have been landed. Closing bug.
<rdar://problem/33701307>