Bug 141449 - Clients need the ability to hook into immediate action lifecycle
Summary: Clients need the ability to hook into immediate action lifecycle
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Conrad Shultz
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-02-10 16:58 PST by Conrad Shultz
Modified: 2015-02-10 18:08 PST (History)
4 users (show)

See Also:

Attachments
Patch (5.10 KB, patch)
2015-02-10 17:15 PST, Conrad Shultz 		no flags Details | Formatted Diff | Diff
Patch (4.11 KB, patch)
2015-02-10 17:41 PST, Conrad Shultz 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Conrad Shultz 2015-02-10 16:58:11 PST 
Clients need the ability to hook into immediate action lifecycle
Comment 1 Radar WebKit Bug Importer 2015-02-10 16:59:23 PST 
<rdar://problem/19790407>
Comment 2 Conrad Shultz 2015-02-10 17:15:08 PST 
Created attachment 246352 [details]
Patch
Comment 3 Tim Horton 2015-02-10 17:18:29 PST 
Comment on attachment 246352 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246352&action=review

> Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:183
> +    [_wkView _beginImmediateAction];

This is about beginning the animation, not the action.

> Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:206
> +    [_wkView _updateImmediateAction];

Ditto.

> Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:216
> +    [_wkView _cancelImmediateAction];

Ditto.

> Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:228
> +    [_wkView _completeImmediateAction];

This is where the action begins.
Comment 4 Conrad Shultz 2015-02-10 17:28:15 PST 
Good point, I'll post a revised version.
Comment 5 Conrad Shultz 2015-02-10 17:41:57 PST 
Created attachment 246356 [details]
Patch
Comment 6 Conrad Shultz 2015-02-10 18:08:50 PST 
Committed r179909: <http://trac.webkit.org/changeset/179909>