Bug 141447 - Add another assertion to help track down crash in DocumentLoader::stopLoadingForPolicyChange()
Summary: Add another assertion to help track down crash in DocumentLoader::stopLoading...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-02-10 15:15 PST by Chris Dumez
Modified: 2015-02-10 15:59 PST (History)
3 users (show)

See Also:

Attachments
Patch (2.42 KB, patch)
2015-02-10 15:19 PST, Chris Dumez 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-02-10 15:15:28 PST 
Add another assertion to help track down crash in DocumentLoader::stopLoadingForPolicyChange().

The trace seems to hint that frameLoader() returns null when stopLoadingForPolicyChange() is called. frameLoader() can only return null after DocumentLoader::detachFromFrame() has been called.
Also, stopLoadingForPolicyChange() here is called from the DocumentLoader::continueAfterContentPolicy() policy callback which requires m_waitingForContentPolicy to be true. Therefore, we should assert that m_waitingForContentPolicy is false when m_frame is cleared in DocumentLoader::detachFromFrame().

Radar: <rdar://problem/13811738>
Comment 1 Chris Dumez 2015-02-10 15:19:26 PST 
Created attachment 246347 [details]
Patch
Comment 2 Chris Dumez 2015-02-10 15:59:10 PST 
Committed r179895: <http://trac.webkit.org/changeset/179895>