WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
141447
Add another assertion to help track down crash in DocumentLoader::stopLoadingForPolicyChange()
https://bugs.webkit.org/show_bug.cgi?id=141447
Summary
Add another assertion to help track down crash in DocumentLoader::stopLoading...
Chris Dumez
Reported
2015-02-10 15:15:28 PST
Add another assertion to help track down crash in DocumentLoader::stopLoadingForPolicyChange(). The trace seems to hint that frameLoader() returns null when stopLoadingForPolicyChange() is called. frameLoader() can only return null after DocumentLoader::detachFromFrame() has been called. Also, stopLoadingForPolicyChange() here is called from the DocumentLoader::continueAfterContentPolicy() policy callback which requires m_waitingForContentPolicy to be true. Therefore, we should assert that m_waitingForContentPolicy is false when m_frame is cleared in DocumentLoader::detachFromFrame(). Radar: <
rdar://problem/13811738
>
Attachments
Patch
(2.42 KB, patch)
2015-02-10 15:19 PST
,
Chris Dumez
ap
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2015-02-10 15:19:26 PST
Created
attachment 246347
[details]
Patch
Chris Dumez
Comment 2
2015-02-10 15:59:10 PST
Committed
r179895
: <
http://trac.webkit.org/changeset/179895
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug