I will be handling these 6 extensions and promoting them to core. OES_standard_derivatives OES_element_index_uint EXT_sRGB EXT_blend_minmax EXT_frag_depth EXT_shader_texture_lod The other 3 already have other bugs tracking their progress.
Created attachment 246346 [details] patch I don't yet have finalized tests ready to be landed for these changes (though I've confirmed that it works some hacked together tests locally). I'm working on other stuff now though so I just wanted to stick this patch up here for now to let EWS do its thing and for safe keeping (in case I run into a situation where I have to wipe my machine and all its data...which has happened to me more than once...)
Attachment 246346 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 246346 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=246346&action=review r=me, but please deal with the missing Bugzilla entry? > Source/WebCore/ChangeLog:4 > + rdar://problem/19633715. Please file a related Bugzilla entry as well. > Source/WebCore/html/canvas/WebGLRenderingContext.cpp:1151 > + maxIndex = std::max(maxIndex, static_cast<int>(p[i])); These snippets of code are scattered all through these WebGL classes. Couldn't we make these into templates of some kind to simplify the code? Although, I guess this is just code moved from elsewhere. But could we do a clean-up pass to reduce some of this code duplication?
Landed: http://trac.webkit.org/changeset/180285 Many of these methods in the WebGL2 implementation are still subject to change. I think before I start creating lots of helper methods that take lots of parameters to avoid code duplication, I'd like the implementation to become a little more finalized.