Bug 141445 - New perf dashboard shouldn't always show outliers
Summary: New perf dashboard shouldn't always show outliers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Perf Dashboard (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 141237
  Show dependency tree / graph
 
Reported: 2015-02-10 15:04 PST by Ryosuke Niwa
Modified: 2016-02-16 13:52 PST (History)
3 users (show)

See Also:

Attachments
Fixes the bug (14.25 KB, patch)
2015-02-10 15:19 PST, Ryosuke Niwa 		cdumez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2015-02-10 15:04:46 PST 
It's inconvenient to always show outliners.
Use a moving average's envelope to compute the y-axis range to show instead.
Comment 1 Ryosuke Niwa 2015-02-10 15:19:29 PST 
Created attachment 246348 [details]
Fixes the bug
Comment 2 Chris Dumez 2015-02-10 15:25:30 PST 
Comment on attachment 246348 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=246348&action=review

r=me with 1 fix.

> Websites/perf.webkit.org/public/v2/app.js:493
> +            chartData.hideEnveope = true;

hideEnveope -> hideEnvelope

> Websites/perf.webkit.org/public/v2/interactive-chart.js:358
> +            currentRange[0] = Math.min(0, currentRange[0]);

So currentRange[0] can be negative?
Comment 3 Ryosuke Niwa 2015-02-10 18:35:41 PST 
(In reply to comment #2)
> Comment on attachment 246348 [details]
> Fixes the bug
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=246348&action=review
> 
> r=me with 1 fix.

Thanks!

> > Websites/perf.webkit.org/public/v2/app.js:493
> > +            chartData.hideEnveope = true;
> 
> hideEnveope -> hideEnvelope

Fixed.

> > Websites/perf.webkit.org/public/v2/interactive-chart.js:358
> > +            currentRange[0] = Math.min(0, currentRange[0]);
> 
> So currentRange[0] can be negative?

Yes. There's nothing that prevents a perf. test from reporting a negative number.
Comment 4 Ryosuke Niwa 2015-02-10 18:45:43 PST 
Committed r179913: <http://trac.webkit.org/changeset/179913>