Bug 141438 – New perf dashboard should have the ability to overlay moving average with an envelope

• Status: RESOLVED
• Resolution: FIXED
• Component: Perf Dashboard

[Ryosuke Niwa]

In order to hide outliers and detect new regressions automatically, we need a way to try out different kinds of moving averages and enveloping strategies.
Add the ability to show that visually on our graphs.

[Ryosuke Niwa]

Created attachment 246340 [details]
Patch

[Andreas Kling]

Comment on attachment 246340 [details]
Patch

rs=me

[Chris Dumez]

Comment on attachment 246340 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246340&action=review

> Websites/perf.webkit.org/public/v2/app.js:441
> +        var strategies = Statistics.EnvelopingStrategies.map(this._cloneStrategy.bind(this));

Isn't it confusing to reuse the same variable name as before?

> Websites/perf.webkit.org/public/v2/app.js:447
> +        var parametreList = (strategy.parameterList || []).map(function (param) { return Ember.Object.create(param); });

parametreList -> parameterList

[Chris Dumez]

Comment on attachment 246340 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246340&action=review

> Websites/perf.webkit.org/public/v2/app.js:466
> +        for (var i = 0; i < chosenStrategy.parameters; i++)

chosenStrategy.parameters.length ?

[Chris Dumez]

Comment on attachment 246340 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246340&action=review

> Websites/perf.webkit.org/public/v2/js/statistics.js:112
> +                var sum = 0;

redundant? already inside the loop.

> Websites/perf.webkit.org/public/v2/js/statistics.js:113
> +                var i = 0;

redundant? already inside the loop.

[Ryosuke Niwa]

Thanks for the reviews. Will land addresssing those comments.

[Ryosuke Niwa]

Committed r179878: <http://trac.webkit.org/changeset/179878>