Bug 141435 – [CSS Grid Layout] Columns set in percentages collapse to auto width

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Manuel Rego Casasnovas]

A very simple example where you use percentages to set columns and the width of the grid container is auto is not working as expected:

<div style="display: -webkit-grid; -webkit-grid-template-columns: 50% 50%;">
  <div>item 1</div>
  <div>item 2</div>
</div>

It's being interpreted as "auto auto" which is wrong, it should use the 50% of the width of the grid. As despite of being "auto" it doesn't mean it's indefinite.

This was discussed in the CSS WG mailing list, more details in the following thread:
http://lists.w3.org/Archives/Public/www-style/2014Aug/0364.html

This has been already fixed in Blink: http://code.google.com/p/chromium/issues/detail?id=407089

[Manuel Rego Casasnovas]

Created attachment 246329 [details]
Patch

[Manuel Rego Casasnovas]

Created attachment 246330 [details]
Patch

[Sergio Villar Senin]

Comment on attachment 246330 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246330&action=review

> Source/WebCore/rendering/RenderBox.cpp:4453
> +        return true;

Perhaps we could merge these three in a single condition.

[Manuel Rego Casasnovas]

Created attachment 248582 [details]
Patch

[Manuel Rego Casasnovas]

New version of the patch merging several fixes from Blink:
* https://codereview.chromium.org/906323003
* https://codereview.chromium.org/914993003
* https://codereview.chromium.org/948833002
* https://codereview.chromium.org/946553003

[Manuel Rego Casasnovas]

Adding more reviewers on CC from suggest-reviewers. Please, could someone take a look? Thanks!

[Dave Hyatt]

Comment on attachment 248582 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 248582 [details]
Patch

Rejecting attachment 248582 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 248582, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/5540314462814208

[Manuel Rego Casasnovas]

Created attachment 250673 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 250673 [details]
Patch for landing

Clearing flags on attachment: 250673

Committed r182780: <http://trac.webkit.org/changeset/182780>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.