Bug 14142 - SVG text gradients are busted on feature-branch
Summary: SVG text gradients are busted on feature-branch
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Eric Seidel (no email)
Depends on:
Reported: 2007-06-14 12:21 PDT by Eric Seidel (no email)
Modified: 2007-06-14 15:38 PDT (History)
0 users

See Also:

the fix (10.62 KB, patch)
2007-06-14 12:23 PDT, Eric Seidel (no email)
zimmermann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2007-06-14 12:21:51 PDT
SVG text gradients are busted on feature-branch

This happened due to my adding painting outline support.  The one-line fix is thus:

Index: rendering/SVGRootInlineBox.cpp
--- rendering/SVGRootInlineBox.cpp      (revision 23529)
+++ rendering/SVGRootInlineBox.cpp      (working copy)
@@ -112,7 +113,7 @@
 void SVGRootInlineBox::paint(RenderObject::PaintInfo& paintInfo, int tx, int ty)
-    if (paintInfo.context->paintingDisabled())
+    if (paintInfo.context->paintingDisabled() || paintInfo.phase != PaintPhaseForeground)
     FloatRect boundingBox;

I don't think the root inline box needs to ever paint in any other phase.

I also did a small amount of clenaup in this patch.
Comment 1 Eric Seidel (no email) 2007-06-14 12:23:22 PDT
Created attachment 15027 [details]
the fix
Comment 2 Nikolas Zimmermann 2007-06-14 12:26:31 PDT
Comment on attachment 15027 [details]
the fix

Looks good. Nice work!
Comment 3 Nikolas Zimmermann 2007-06-14 15:38:29 PDT
Landed in r23533.