RESOLVED FIXED 141403
Web Inspector: backend command promises are not rejected when a protocol error occurs 
https://bugs.webkit.org/show_bug.cgi?id=141403
Summary Web Inspector: backend command promises are not rejected when a protocol erro...
Brian Burg
Reported 2015-02-09 14:34:52 PST
I would expect that DOMAgent.highlightNode.promise() [missing a single required argument] would cause the promise to be rejected, but instead it is fulfilled with value 'null', while logging something to the console. What is the expected behavior here?
Attachments
Proposed Fix (15.84 KB, patch)
2015-09-14 15:31 PDT, Blaze Burg 		joepeck: review+
joepeck: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-02-09 14:35:24 PST
<rdar://problem/19772080>
Timothy Hatcher
Comment 2 2015-02-12 19:33:37 PST
I agree it should reject if it is missing required arguments.
Blaze Burg
Comment 3 2015-09-14 14:36:18 PDT
I have written a test for this new behavior, and am implementing changes now.
Blaze Burg
Comment 4 2015-09-14 15:31:01 PDT
Created attachment 261142 [details] Proposed Fix
WebKit Commit Bot
Comment 5 2015-09-14 15:33:18 PDT
Attachment 261142 [details] did not pass style-queue: ERROR: Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:493: Line contains single-quote character. [js/syntax] [5] ERROR: Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:500: Line contains single-quote character. [js/syntax] [5] ERROR: Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:506: Line contains single-quote character. [js/syntax] [5] Total errors found: 3 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Joseph Pecoraro
Comment 6 2015-09-14 16:39:32 PDT
Comment on attachment 261142 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=261142&action=review r=me > LayoutTests/inspector/protocol/inspector-backend-invocation-return-value-expected.txt:25 > +PASS: a successful command should invoke the callback with a 'null' first parameter. Lots of lowercase "a"s in here that should be capitalized. > LayoutTests/inspector/protocol/inspector-backend-invocation-return-value.html:125 > + description: "Backend command's returned promise should be rejected if the command lacks required arguments.", Nit: "Backend command's returned promise ..." => "Backend command callback ..."
Blaze Burg
Comment 7 2015-09-14 17:10:14 PDT
Committed r189761: <http://trac.webkit.org/changeset/189761>
Note You need to log in before you can comment on or make changes to this bug.