Implement WebColorPicker and enable INPUT_TYPE_COLOR by default. API to override the default implementation will be added in bug #98935
Created attachment 246276 [details] Patch
Committed r179922: <http://trac.webkit.org/changeset/179922>
Also unskipped the input color tests when landing the patch, that I had forgotten :-)
Hah, I thought the layout tests would be independent of the platform implementation.
(In reply to comment #4) > Hah, I thought the layout tests would be independent of the platform > implementation. Yes, but the patch enables INPUT_TYPE_COLOR, so now we render a color button instead of a text entry and all the logic behind ENABLE(INPUT_TYPE_COLOR) works as well.
FYI, webkitgtk cannot build anymore if INPUT_TYPE_COLOR is deactivated manually. For instance WebKitColorChooser is not under ENABLE(INPUT_TYPE_COLOR) compile flag but is inheriting from WebColorPickerGtk under INPUT_TYPE_COLOR. Is it done on purpose ? ( = INPUT_TYPE_COLOR is now mandatory) or should we support INPUT_TYPE_COLOR on/off ? (= INPUT_TYPE_COLOR check should be added everywhere) Thanks for your feedback :)
(In reply to comment #6) > FYI, webkitgtk cannot build anymore if INPUT_TYPE_COLOR is deactivated > manually. > > For instance WebKitColorChooser is not under ENABLE(INPUT_TYPE_COLOR) > compile flag but is inheriting from WebColorPickerGtk under INPUT_TYPE_COLOR. > > Is it done on purpose ? > ( = INPUT_TYPE_COLOR is now mandatory) Yes, it's on purpose, why do you want to disable it? > or should we support INPUT_TYPE_COLOR on/off ? > (= INPUT_TYPE_COLOR check should be added everywhere) > > Thanks for your feedback :)
I don't want to deactivate it (though I guess I don't really need it). Anyway use the default webkitgtk configuration (INPUT_TYPE_COLOR = ON) is ok, thanks for answer.