Bug 141392 – [GTK] Add default color chooser implementation using GtkColorChooserDialog

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Garcia Campos]

Implement WebColorPicker and enable INPUT_TYPE_COLOR by default. API to override the default implementation will be added in bug #98935

[Carlos Garcia Campos]

Created attachment 246276 [details]
Patch

[Carlos Garcia Campos]

Committed r179922: <http://trac.webkit.org/changeset/179922>

[Carlos Garcia Campos]

Also unskipped the input color tests when landing the patch, that I had forgotten :-)

[Gustavo Noronha (kov)]

Hah, I thought the layout tests would be independent of the platform implementation.

[Carlos Garcia Campos]

(In reply to comment #4)
> Hah, I thought the layout tests would be independent of the platform
> implementation.

Yes, but the patch enables INPUT_TYPE_COLOR, so now we render a color button instead of a text entry and all the logic behind ENABLE(INPUT_TYPE_COLOR) works as well.

[Fabien Vallée]

FYI, webkitgtk cannot build anymore if INPUT_TYPE_COLOR is deactivated manually.

For instance WebKitColorChooser is not under ENABLE(INPUT_TYPE_COLOR) compile flag but is inheriting from WebColorPickerGtk under INPUT_TYPE_COLOR.

Is it done on purpose ? 
( = INPUT_TYPE_COLOR is now mandatory)

or should we support INPUT_TYPE_COLOR on/off ? 
(= INPUT_TYPE_COLOR  check should be added everywhere) 

Thanks for your feedback :)

[Carlos Garcia Campos]

(In reply to comment #6)
> FYI, webkitgtk cannot build anymore if INPUT_TYPE_COLOR is deactivated
> manually.
> 
> For instance WebKitColorChooser is not under ENABLE(INPUT_TYPE_COLOR)
> compile flag but is inheriting from WebColorPickerGtk under INPUT_TYPE_COLOR.
> 
> Is it done on purpose ? 
> ( = INPUT_TYPE_COLOR is now mandatory)

Yes, it's on purpose, why do you want to disable it?

> or should we support INPUT_TYPE_COLOR on/off ? 
> (= INPUT_TYPE_COLOR  check should be added everywhere) 
> 
> Thanks for your feedback :)

[Fabien Vallée]

I don't want to deactivate it (though I guess I don't really need it).
Anyway use the default webkitgtk configuration (INPUT_TYPE_COLOR = ON) is ok, thanks for answer.