Bug 141388 - Varargs frame set-up should be factored out for use by other JITs
Summary: Varargs frame set-up should be factored out for use by other JITs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 141332
  Show dependency tree / graph
 
Reported: 2015-02-09 09:47 PST by Filip Pizlo
Modified: 2015-02-09 19:28 PST (History)
11 users (show)

See Also:

Attachments
the patch (58.30 KB, patch)
2015-02-09 09:56 PST, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (58.54 KB, patch)
2015-02-09 10:52 PST, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (59.36 KB, patch)
2015-02-09 12:13 PST, Filip Pizlo 		msaboff: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-02-09 09:47:02 PST 
Currently there is a lot of code that is tightly-coupled to the baseline engines' view of the world - i.e. literal execution of bytecode.  There is even more code that does smart things for varargs that is inside the baseline JIT itself.

We should move that code out and make it more general, for example make it respect the notion that not everyone executes bytecode.
Comment 1 Filip Pizlo 2015-02-09 09:56:45 PST 
Created attachment 246274 [details]
the patch
Comment 2 Filip Pizlo 2015-02-09 10:52:41 PST 
Created attachment 246278 [details]
the patch

Some 32-bit fixes.
Comment 3 Filip Pizlo 2015-02-09 12:13:04 PST 
Created attachment 246282 [details]
the patch

32-bit works again.
Comment 4 Michael Saboff 2015-02-09 13:58:40 PST 
Comment on attachment 246282 [details]
the patch

r=me
Comment 5 Filip Pizlo 2015-02-09 19:28:05 PST 
Landed in http://trac.webkit.org/changeset/179862