RESOLVED FIXED 141378
Measure cache size more accurately 
https://bugs.webkit.org/show_bug.cgi?id=141378
Summary Measure cache size more accurately
Antti Koivisto
Reported 2015-02-08 16:59:00 PST
Currently we just estimate from the item count.
Attachments
patch (8.43 KB, patch)
2015-02-08 17:15 PST, Antti Koivisto 		cdumez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2015-02-08 17:15:51 PST
Created attachment 246253 [details] patch
Antti Koivisto
Comment 2 2015-02-08 17:16:39 PST
rdar://problem/19760224
Chris Dumez
Comment 3 2015-02-08 19:33:41 PST
Comment on attachment 246253 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=246253&action=review r=me with comments > Source/WebKit2/NetworkProcess/cache/NetworkCacheStorageCocoa.mm:458 > + m_approximateSize += bodyOffset + bodySize; Why are we adding an offset to the size here? Maybe it is just a naming issue but it looks wrong. > Source/WebKit2/NetworkProcess/cache/NetworkCacheStorageCocoa.mm:554 > + static const double deletionProbability { 0.25 }; Maybe a ASSERT(RunLoop::isMain()); before this? > Source/WebKit2/NetworkProcess/cache/NetworkCacheStorageCocoa.mm:572 > + bool shouldDelete = randomNumber() < deletionProbability; Is it safe to call randomNumber() from another thread? The implementation seems to call sharedRandomNumberGenerator() which is a singleton.
Antti Koivisto
Comment 4 2015-02-09 02:11:13 PST
> Is it safe to call randomNumber() from another thread? The implementation > seems to call sharedRandomNumberGenerator() which is a singleton. sharedRandomNumberGenerator() is ARC4RandomNumberGenerator which is thread safe (internal mutex).
Antti Koivisto
Comment 5 2015-02-09 03:36:07 PST
http://trac.webkit.org/changeset/179823
Note You need to log in before you can comment on or make changes to this bug.