WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
REOPENED
141364
fullscreen/full-screen-plugin.html is very flaky on Yosemite WK2
https://bugs.webkit.org/show_bug.cgi?id=141364
Summary
fullscreen/full-screen-plugin.html is very flaky on Yosemite WK2
Alexey Proskuryakov
Reported
2015-02-07 15:49:39 PST
fullscreen/full-screen-plugin.html fails on Yosemite WK2 about 50% of the time: <
http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&showExpectations=true&revision=179781&tests=fullscreen%2Ffull-screen-plugin.html
>. This test was added in <
http://trac.webkit.org/r170717
>. @@ -1,3 +1,3 @@ Test that plugin doesn't restart when taking it to full screen and back. -SUCCESS +FAIL
Attachments
speculative fix
(1.74 KB, patch)
2015-02-07 19:41 PST
,
Alexey Proskuryakov
no flags
Details
Formatted Diff
Diff
second try
(1.36 KB, patch)
2015-02-08 11:28 PST
,
Alexey Proskuryakov
sam
: review+
commit-queue
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2015-02-07 19:41:14 PST
Created
attachment 246230
[details]
speculative fix
WebKit Commit Bot
Comment 2
2015-02-07 21:24:31 PST
Comment on
attachment 246230
[details]
speculative fix Clearing flags on attachment: 246230 Committed
r179794
: <
http://trac.webkit.org/changeset/179794
>
WebKit Commit Bot
Comment 3
2015-02-07 21:24:36 PST
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 4
2015-02-08 11:22:44 PST
This made the test fail differently, shedding more light on why it failed before: -Test that plugin doesn't restart when taking it to full screen and back. -SUCCESS +CONSOLE MESSAGE: line 26: TypeError: undefined is not an object (evaluating 'testObject.property = 'foo'') +FAIL: Timed out waiting for notifyDone to be called Apparently, testObject is not necessarily available even by the time the load event fires.
Alexey Proskuryakov
Comment 5
2015-02-08 11:28:49 PST
Created
attachment 246244
[details]
second try
Sam Weinig
Comment 6
2015-02-08 13:37:57 PST
Comment on
attachment 246244
[details]
second try View in context:
https://bugs.webkit.org/attachment.cgi?id=246244&action=review
> LayoutTests/fullscreen/full-screen-plugin.html:65 > +function checkForPlugin() > +{ > + var plugin = document.getElementById('plugin'); > + if (plugin.testObject) > + test(); > + else > + setTimeout(checkForPlugin, 100); > +}
It seems like it might make sense for the test plugin to have a way to indicate it is ready without the need to poll. Maybe the plugin could look for a predefined function name (e.g. function pluginIsAvailable()) and call it when it has been instantiated. I can't imagine this is the only place where this mistake is made.
Alexey Proskuryakov
Comment 7
2015-02-08 17:19:14 PST
I thought that plug-ins were supposed to be available in onload, however maybe some of the async layout patches broke that. Or maybe it never worked correctly in WebKit.
WebKit Commit Bot
Comment 8
2015-02-08 17:20:42 PST
Comment on
attachment 246244
[details]
second try Rejecting
attachment 246244
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 246244, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output:
http://webkit-queues.appspot.com/results/5013007134359552
Alexey Proskuryakov
Comment 9
2015-02-08 17:25:31 PST
Committed <
http://trac.webkit.org/r179811
>.
Alexey Proskuryakov
Comment 10
2015-02-10 18:12:43 PST
Hmm, it still fails. @@ -1,3 +1,2 @@ -Test that plugin doesn't restart when taking it to full screen and back. -SUCCESS +FAIL: Timed out waiting for notifyDone to be called
Alexey Proskuryakov
Comment 11
2015-02-16 13:47:48 PST
Marked as flaky in <
http://trac.webkit.org/changeset/180170
>. Antti, this is a test for your fix, please make it work correctly if you can.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug