Bug 141358 - [iOS] Make Simulator class testable
Summary: [iOS] Make Simulator class testable
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
Depends on:
Blocks: 141365
  Show dependency treegraph
Reported: 2015-02-07 10:48 PST by David Kilzer (:ddkilzer)
Modified: 2015-02-07 16:44 PST (History)
8 users (show)

See Also:

Patch v1 (17.40 KB, patch)
2015-02-07 10:58 PST, David Kilzer (:ddkilzer)
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2015-02-07 10:48:03 PST
Need to make the Simulator class testable so that another bug can be fixed by writing a new failing test, then fixing that test.
Comment 1 David Kilzer (:ddkilzer) 2015-02-07 10:58:26 PST
Created attachment 246210 [details]
Patch v1
Comment 2 Darin Adler 2015-02-07 11:08:55 PST
Comment on attachment 246210 [details]
Patch v1

Comment 3 David Kilzer (:ddkilzer) 2015-02-07 16:14:14 PST
Comment on attachment 246210 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=246210&action=review

> Tools/Scripts/webkitpy/xcode/simulator_unittest.py:24
> +import os
> +import re

These imports are not needed.  Will remove them before landing.
Comment 4 David Kilzer (:ddkilzer) 2015-02-07 16:44:43 PST
Committed r179788: <http://trac.webkit.org/changeset/179788>