This should land in concert with this JSC change: https://bugs.webkit.org/show_bug.cgi?id=141095
<rdar://problem/19747067>
Created attachment 246168 [details] the patch
Comment on attachment 246168 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=246168&action=review r=me > Source/WebInspectorUI/UserInterface/Views/TextEditor.js:464 > + var options = { Meh, could be inlined still =)
Created attachment 246334 [details] patch Patch slightly changed. I don't think CodeMirror Actually respects the inclusiveLeft/Right options. I tried all variations of the 2^2=4 assignments to inclusiveLeft/Right and I couldn't get the text marking to behave any differently. I couldn't figure out why this is, it may be worth filing a bug with CodeMirror if this is indeed the case. Anyways, I found that if you have a text range [start, end], then the range that CodeMirror actually marks is such: [start, end). This patch compensates for this by adding one to the end position's offset.
Comment on attachment 246334 [details] patch You should file a CodeMirror bug with a simple test case.
Comment on attachment 246334 [details] patch Clearing flags on attachment: 246334 Committed r180526: <http://trac.webkit.org/changeset/180526>
All reviewed patches have been landed. Closing bug.