Bug 141334 - Web Inspector: BasicBlockAnnotator ranges should be inclusive of both the start and end offset
Summary: Web Inspector: BasicBlockAnnotator ranges should be inclusive of both the sta...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Saam Barati
Keywords: InRadar
Depends on: 141095
  Show dependency treegraph
Reported: 2015-02-06 11:11 PST by Saam Barati
Modified: 2015-02-23 15:18 PST (History)
8 users (show)

See Also:

the patch (1.58 KB, patch)
2015-02-06 11:47 PST, Saam Barati
joepeck: review+
Details | Formatted Diff | Diff
patch (1.53 KB, patch)
2015-02-10 12:05 PST, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2015-02-06 11:11:16 PST
This should land in concert with this JSC change:
Comment 1 Radar WebKit Bug Importer 2015-02-06 11:11:41 PST
Comment 2 Saam Barati 2015-02-06 11:47:30 PST
Created attachment 246168 [details]
the patch
Comment 3 Joseph Pecoraro 2015-02-06 11:50:14 PST
Comment on attachment 246168 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246168&action=review


> Source/WebInspectorUI/UserInterface/Views/TextEditor.js:464
> +        var options = {

Meh, could be inlined still =)
Comment 4 Saam Barati 2015-02-10 12:05:39 PST
Created attachment 246334 [details]

Patch slightly changed.
I don't think CodeMirror Actually respects the inclusiveLeft/Right options.
I tried all variations of the 2^2=4 assignments to inclusiveLeft/Right and I couldn't
get the text marking to behave any differently. I couldn't figure out why this is, it may
be worth filing a bug with CodeMirror if this is indeed the case. Anyways, I found that
if you have a text range [start, end], then the range that CodeMirror actually marks is such:
[start, end).

This patch compensates for this by adding one to the end position's offset.
Comment 5 Timothy Hatcher 2015-02-10 13:10:26 PST
Comment on attachment 246334 [details]

You should file a CodeMirror bug with a simple test case.
Comment 6 WebKit Commit Bot 2015-02-23 15:18:45 PST
Comment on attachment 246334 [details]

Clearing flags on attachment: 246334

Committed r180526: <http://trac.webkit.org/changeset/180526>
Comment 7 WebKit Commit Bot 2015-02-23 15:18:50 PST
All reviewed patches have been landed.  Closing bug.