Bug 141330 - [GTK] Remove WebKitWebView::close-notification signal
Summary: [GTK] Remove WebKitWebView::close-notification signal
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2015-02-06 05:28 PST by Carlos Garcia Campos
Modified: 2015-02-06 06:50 PST (History)
1 user (show)

See Also:


Attachments
Patch (23.13 KB, patch)
2015-02-06 05:42 PST, Carlos Garcia Campos
gns: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2015-02-06 05:28:07 PST
In favor of a WebKitNotification::closed signal. There are two main reasons for this:

 1.- We are running out of padding space in WebKitWebViewClass
 2.- Applications should be able to close notifications too. Right now, in the default implementation when the user closes a notification, the web view is not notified, so the notification remains alive and onclose handler is not dispatched either.
Comment 1 Carlos Garcia Campos 2015-02-06 05:42:07 PST
Created attachment 246162 [details]
Patch
Comment 2 Gustavo Noronha (kov) 2015-02-06 05:58:11 PST
Comment on attachment 246162 [details]
Patch

So back to having the close signal on the notification and fixing a DOM notification that was not being emitted - I wonder if there are tests that we can unskip for that?
Comment 3 Carlos Garcia Campos 2015-02-06 06:13:55 PST
(In reply to comment #2)
> Comment on attachment 246162 [details]
> Patch
> 
> So back to having the close signal on the notification and fixing a DOM
> notification that was not being emitted - I wonder if there are tests that
> we can unskip for that?

This only affects the GTK+ API, not the C API used by WTR, so I don't think this can fix any test
Comment 4 Carlos Garcia Campos 2015-02-06 06:50:34 PST
Committed r179745: <http://trac.webkit.org/changeset/179745>