In favor of a WebKitNotification::closed signal. There are two main reasons for this: 1.- We are running out of padding space in WebKitWebViewClass 2.- Applications should be able to close notifications too. Right now, in the default implementation when the user closes a notification, the web view is not notified, so the notification remains alive and onclose handler is not dispatched either.
Created attachment 246162 [details] Patch
Comment on attachment 246162 [details] Patch So back to having the close signal on the notification and fixing a DOM notification that was not being emitted - I wonder if there are tests that we can unskip for that?
(In reply to comment #2) > Comment on attachment 246162 [details] > Patch > > So back to having the close signal on the notification and fixing a DOM > notification that was not being emitted - I wonder if there are tests that > we can unskip for that? This only affects the GTK+ API, not the C API used by WTR, so I don't think this can fix any test
Committed r179745: <http://trac.webkit.org/changeset/179745>