Bug 141312 - Dashboard doesn't consider building ASan a productive step
Summary: Dashboard doesn't consider building ASan a productive step
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-05 16:08 PST by Alexey Proskuryakov
Modified: 2015-02-05 16:30 PST (History)
1 user (show)

See Also:

Attachments
proposed fix (1.55 KB, patch)
2015-02-05 16:13 PST, Alexey Proskuryakov 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2015-02-05 16:08:05 PST 
This breaks displaying how far behind we are, possibly more.
Comment 1 Alexey Proskuryakov 2015-02-05 16:13:03 PST 
Created attachment 246136 [details]
proposed fix

I started to wonder if we should consider "build" a productive step, or "upload". Is the builder behind if it successfully built, but failed to upload, and needs to build again?

On one hand, it did tell us whether the build is broken, but on another hand, it didn't provide any binaries to testers.

This patch just keeps with tradition.
Comment 2 Simon Fraser (smfr) 2015-02-05 16:20:28 PST 
Comment on attachment 246136 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=246136&action=review

> Tools/ChangeLog:15
> +2015-02-05  Alexey Proskuryakov  <ap@apple.com>
> +
> +        Need a short description (OOPS!).
> +        Need the bug URL (OOPS!).
> +
> +        Reviewed by NOBODY (OOPS!).

OOPS
Comment 3 Alexey Proskuryakov 2015-02-05 16:30:58 PST 
Committed <http://trac.webkit.org/r179721>.