Bug 141307 - [iOS] Remove False Positive dispatch_source Leak in WebMemoryPressureHandler singleton
Summary: [iOS] Remove False Positive dispatch_source Leak in WebMemoryPressureHandler ...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
Depends on:
Reported: 2015-02-05 14:46 PST by Joseph Pecoraro
Modified: 2015-02-05 15:47 PST (History)
3 users (show)

See Also:

[PATCH] Proposed Fix (2.60 KB, patch)
2015-02-05 14:47 PST, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-02-05 14:46:45 PST
Remove False Positive OS_dispatch_source Leak in WebMemoryPressureHandler singleton.

I think we actually want to always keep this dispatch_source around. So we should just add a reference to it in WebMemoryPressureHandler.

Leak: 0x1657a1f0  size=112  zone: DefaultMallocZone_0x197e000   OS_dispatch_source  ObjC  libdispatch.dylib
	Call stack: [thread 0x3676a9d0]: 
        | start 
        | 0x4c0e1 
        | UIApplicationMain 
        | -[UIApplication _run] 
        | -[WKProcessPool(WKPrivate) _initWithConfiguration:] 
        | WebKit::WebProcessPool::WebProcessPool(API::ProcessPoolConfiguration&) 
        | WebKit::WebMemoryPressureHandler::shared() 
        | WebKit::WebMemoryPressureHandler::WebMemoryPressureHandler() 
        | dispatch_source_create 
        | _os_object_alloc_realized 
        | class_createInstance 
        | calloc 
        | malloc_zone_calloc
Comment 1 Joseph Pecoraro 2015-02-05 14:47:38 PST
Created attachment 246132 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2015-02-05 15:47:41 PST
Comment on attachment 246132 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 246132

Committed r179720: <http://trac.webkit.org/changeset/179720>
Comment 3 WebKit Commit Bot 2015-02-05 15:47:45 PST
All reviewed patches have been landed.  Closing bug.