Bug 141302 - EWS fails to process or release security patches
Summary: EWS fails to process or release security patches
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-05 12:53 PST by Alexey Proskuryakov
Modified: 2015-02-05 12:53 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2015-02-05 12:53:15 PST 
Strange things happen when a EWS bot tries to process a patch from a security bug, even if both commit-queue and buildbot@hotmail.com are CC'ed on the bug.

Processing starts, but fails, and the patch fails to be released.

[05/Feb/2015:11:57:22 -0800] "POST /release-patch HTTP/1.1" 500 596 "http://webkit-queues.appspot.com/release-patch" "Python-urllib/2.7" "webkit-queues.appspot.com" ms=48 cpu_ms=20 cpm_usd=0.000067 app_engine_release=1.9.17 instance=00c61b117ce810a630c9777072dc0aec8bcefc19
E 2015-02-05 11:57:22.628
'NoneType' object has no attribute 'message'
Traceback (most recent call last):
  File "/base/data/home/runtimes/python/python_lib/versions/1/google/appengine/ext/webapp/_webapp25.py", line 717, in __call__
    handler.post(*groups)
  File "/base/data/home/apps/webkit-queues/178455.381522992119632143/handlers/releasepatch.py", line 58, in post
    RecordPatchEvent.stopped(attachment_id, queue_name, last_status.message)
AttributeError: 'NoneType' object has no attribute 'message'