RESOLVED FIXED 141297
[WK2][Cocoa] Populate m_contentsFilter bloom filter from the main dispatch queue NetworkCacheStorage::initialize() 
https://bugs.webkit.org/show_bug.cgi?id=141297
Summary [WK2][Cocoa] Populate m_contentsFilter bloom filter from the main dispatch qu...
Chris Dumez
Reported 2015-02-05 11:21:31 PST
Populate m_contentsFilter bloom filter from the main dispatch queue NetworkCacheStorage::initialize() to avoid thread-safety issues.
Attachments
Patch (2.32 KB, patch)
2015-02-05 11:25 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2015-02-05 11:25:51 PST
Created attachment 246116 [details] Patch
Antti Koivisto
Comment 2 2015-02-05 13:05:43 PST
Comment on attachment 246116 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246116&action=review > Source/WebKit2/NetworkProcess/cache/NetworkCacheStorageCocoa.mm:142 > + dispatch_async(dispatch_get_main_queue(), [this, hash] { > + m_contentsFilter.add(hash); > + }); This gets called a lot so dispatching every item individually is not very optimal. But we can do better later if needed.
WebKit Commit Bot
Comment 3 2015-02-05 13:48:22 PST
Comment on attachment 246116 [details] Patch Clearing flags on attachment: 246116 Committed r179704: <http://trac.webkit.org/changeset/179704>
WebKit Commit Bot
Comment 4 2015-02-05 13:48:28 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.