Bug 141286 - New perf dashboard should compare results to baseline and target
Summary: New perf dashboard should compare results to baseline and target
Alias: None
Product: WebKit
Classification: Unclassified
Component: Perf Dashboard (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
Depends on:
Blocks: 141237
  Show dependency treegraph
Reported: 2015-02-05 00:24 PST by Ryosuke Niwa
Modified: 2016-02-16 13:53 PST (History)
5 users (show)

See Also:

Patch (15.04 KB, patch)
2015-02-05 00:54 PST, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2015-02-05 00:24:43 PST
As done in the v1 dashboard, we should compare results to the baseline and the target values.
Comment 1 Ryosuke Niwa 2015-02-05 00:54:40 PST
Created attachment 246092 [details]
Comment 2 Chris Dumez 2015-02-05 13:25:13 PST
Comment on attachment 246092 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=246092&action=review


> Websites/perf.webkit.org/public/v2/app.js:791
> +        var formatter = d3.format('.3p');

Why don't we use the formatter from chartData?
Comment 3 WebKit Commit Bot 2015-02-05 14:34:19 PST
Comment on attachment 246092 [details]

Clearing flags on attachment: 246092

Committed r179710: <http://trac.webkit.org/changeset/179710>
Comment 4 WebKit Commit Bot 2015-02-05 14:34:24 PST
All reviewed patches have been landed.  Closing bug.