Bug 141276 – Use enum class for GraphicsLayer::ContentsLayerPurpose

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Use enum class for GraphicsLayer::ContentsLayerPurpose

[Simon Fraser (smfr)]

Created attachment 246070 [details]
Patch

[Tim Horton]

Comment on attachment 246070 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246070&action=review

> Source/WebCore/platform/graphics/GraphicsLayer.h:230
> +        NoLayer = 0,

"None"?

[Alexey Proskuryakov]

iOS EWS says:

/Volumes/Data/EWS/WebKit/Source/WebKit/mac/WebView/WebView.mm:3447:78: error: no member named 'ContentsLayerForMedia' in 'WebCore::GraphicsLayer'; did you mean 'contentsLayerForMedia'?

[Ahmad Saleem]

Already done - https://github.com/WebKit/WebKit/blob/6ca6aad73c5b205af1070332ff2a3faba9db5627/Source/WebCore/platform/graphics/GraphicsLayer.h#L510

https://github.com/WebKit/WebKit/blob/4cc03269dc5d1b1e555e47ba70fbfccb31835802/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp#L1227

https://github.com/WebKit/WebKit/blob/4cc03269dc5d1b1e555e47ba70fbfccb31835802/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp#L1239

https://github.com/WebKit/WebKit/blob/4cc03269dc5d1b1e555e47ba70fbfccb31835802/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp#L1264

etc.

I think we can close this.