Bug 141272 – Parser::parseVarDeclarationList gets the wrong JSToken for the last identifier

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

parseVarDeclarationList will turn its last identifier into a pattern if it's not already a pattern node.
But, when doing so, it will pass in the token right after the identifier, not the token corresponding to the identifier.

[Saam Barati]

Created attachment 246069 [details]
patch

will upload with changelog later tonight

[Brent Fulgham]

Do you have a test case showing this problem so we can avoid hitting it in the future?

[Saam Barati]

(In reply to comment #2)
> Do you have a test case showing this problem so we can avoid hitting it in
> the future?

Not directly for asserting the token is at a given location, but the tests I will include when I land: 
https://bugs.webkit.org/show_bug.cgi?id=141241
will fail if we break the token location. That said, this breakage is dependent on the Type Profiler's internal organization of data using text ranges. This is unlikely to change, but there is no guarantee.

Is there a more direct way to assert against the token location of given statement in a JS test?

[Darin Adler]

Comment on attachment 246069 [details]
patch

Bug fix looks good. Needs a change log and a test case.

[Saam Barati]

Created attachment 246316 [details]
patch

[Saam Barati]

landed in:
http://trac.webkit.org/changeset/179873