Bug 141260 - LayoutTestHelper should set the color profile of all displays
Summary: LayoutTestHelper should set the color profile of all displays
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-04 14:01 PST by Simon Fraser (smfr)
Modified: 2015-02-04 15:03 PST (History)
3 users (show)

See Also:

Attachments
Patch (10.68 KB, patch)
2015-02-04 14:03 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (10.77 KB, patch)
2015-02-04 14:12 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
No more ARC (10.15 KB, patch)
2015-02-04 14:30 PST, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2015-02-04 14:01:03 PST 
LayoutTestHelper should set the color profile of all displays
Comment 1 Simon Fraser (smfr) 2015-02-04 14:03:56 PST 
Created attachment 246046 [details]
Patch
Comment 2 Simon Fraser (smfr) 2015-02-04 14:12:14 PST 
Created attachment 246047 [details]
Patch
Comment 3 Tim Horton 2015-02-04 14:14:15 PST 
Comment on attachment 246046 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246046&action=review

> Tools/DumpRenderTree/mac/LayoutTestHelper.m:58
> +    CFUUIDRef uuid = CFUUIDCreateFromString(kCFAllocatorDefault, (__bridge CFStringRef)displayUUIDString);

Leak.

> Tools/DumpRenderTree/mac/LayoutTestHelper.m:82
> +    static const uint32_t maxDisplayCount = 10;

:|

> Tools/DumpRenderTree/mac/LayoutTestHelper.m:98
> +        CFUUIDRef displayUUIDRef = CGDisplayCreateUUIDFromDisplayID(displayIDs[i]);

leak here too

> Tools/DumpRenderTree/mac/LayoutTestHelper.m:124
> +    CFUUIDRef uuid = CFUUIDCreateFromString(kCFAllocatorDefault, (__bridge CFStringRef)displayUUIDString);

yep

> Tools/DumpRenderTree/mac/LayoutTestHelper.m:132
> +    NSMutableDictionary* userColorProfiles = originalColorProfileURLs();

star's on the wrong side

> Tools/DumpRenderTree/mac/LayoutTestHelper.m:149
> +    // space of the display), we force the generic RGB color profile on all displays.

This should say SRGB.
Comment 4 Simon Fraser (smfr) 2015-02-04 14:30:53 PST 
Created attachment 246052 [details]
No more ARC
Comment 5 Tim Horton 2015-02-04 14:34:22 PST 
Comment on attachment 246052 [details]
No more ARC

View in context: https://bugs.webkit.org/attachment.cgi?id=246052&action=review

> Tools/DumpRenderTree/mac/LayoutTestHelper.m:138
> +    NSMutableDictionary* userColorProfiles = originalColorProfileURLs();

Star's on the wrong side.

> Tools/DumpRenderTree/mac/LayoutTestHelper.m:155
> +    // space of the display), we force the generic sRGB color profile on all displays.

not generic :D
Comment 6 Simon Fraser (smfr) 2015-02-04 15:03:24 PST 
https://trac.webkit.org/r179637